Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openssl{,1_1_0} update (1.0.2o, 1.1.0h) #37931

Merged
merged 2 commits into from Mar 27, 2018
Merged

openssl{,1_1_0} update (1.0.2o, 1.1.0h) #37931

merged 2 commits into from Mar 27, 2018

Conversation

andir
Copy link
Member

@andir andir commented Mar 27, 2018

Motivation for this change

Updating openssl to the latest (known secure) version.

See https://www.openssl.org/news/secadv/20180327.txt.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: openssl, openssl_1_1_0

Partial log (click to expand)

checking for references to /build in /nix/store/jpv90dqgvwiz9qpff2avp2v8h9p1a952-openssl-1.1.0h...
shrinking RPATHs of ELF executables and libraries in /nix/store/l6cccvdf3aw0fwbqkjgm30irc2c59fvd-openssl-1.1.0h-man
gzipping man pages under /nix/store/l6cccvdf3aw0fwbqkjgm30irc2c59fvd-openssl-1.1.0h-man/share/man/
patching script interpreter paths in /nix/store/l6cccvdf3aw0fwbqkjgm30irc2c59fvd-openssl-1.1.0h-man
checking for references to /build in /nix/store/l6cccvdf3aw0fwbqkjgm30irc2c59fvd-openssl-1.1.0h-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/k3b2j7pjihsnrfg5bzi9r3n5bfcdjvxj-openssl-1.1.0h-debug
patching script interpreter paths in /nix/store/k3b2j7pjihsnrfg5bzi9r3n5bfcdjvxj-openssl-1.1.0h-debug
checking for references to /build in /nix/store/k3b2j7pjihsnrfg5bzi9r3n5bfcdjvxj-openssl-1.1.0h-debug...
/nix/store/nizmvf71vzyd6l5iz4nqi838z0sqhz4y-openssl-1.0.2o-bin
/nix/store/axgxbh1cgyngyv72k1d7h08m1gx14swk-openssl-1.1.0h-bin

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: openssl, openssl_1_1_0

Partial log (click to expand)

checking for references to /build in /nix/store/2h8l24ky4gvjsad43jv7mhlf5iqpmkmw-openssl-1.1.0h...
shrinking RPATHs of ELF executables and libraries in /nix/store/c9ijlc53rb7a8h8k31hr79rr31qd4b72-openssl-1.1.0h-man
gzipping man pages under /nix/store/c9ijlc53rb7a8h8k31hr79rr31qd4b72-openssl-1.1.0h-man/share/man/
patching script interpreter paths in /nix/store/c9ijlc53rb7a8h8k31hr79rr31qd4b72-openssl-1.1.0h-man
checking for references to /build in /nix/store/c9ijlc53rb7a8h8k31hr79rr31qd4b72-openssl-1.1.0h-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/fyii5bc0v7izmqw95a93a5968bjg4rc9-openssl-1.1.0h-debug
patching script interpreter paths in /nix/store/fyii5bc0v7izmqw95a93a5968bjg4rc9-openssl-1.1.0h-debug
checking for references to /build in /nix/store/fyii5bc0v7izmqw95a93a5968bjg4rc9-openssl-1.1.0h-debug...
/nix/store/cnwa80fivayi8i5bx05k8zgfbv99lv7q-openssl-1.0.2o-bin
/nix/store/xw6afnqjpkcrlhg6ki1pbib59rlmyb7y-openssl-1.1.0h-bin

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: openssl, openssl_1_1_0

Partial log (click to expand)

cannot build derivation '/nix/store/gf9sbbrpg9xamdc93fzx11dqv07kmn7h-cctools-binutils-darwin.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/6zi95nkkn3b8z0qs2j4ybpskzd8cpjka-gnutar-1.30.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/y7j66q4fcx91ad4izbp912sx33bvy2s3-CF-osx-10.10.5.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/ri9wvwmpj3cfbahasj41gsnvz3nd8m2g-cctools-binutils-darwin-wrapper.drv': 7 dependencies couldn't be built
cannot build derivation '/nix/store/h5mjw2f2kl1y7avlc4ymwgn8iv0mmlg8-clang-wrapper-5.0.1.drv': 9 dependencies couldn't be built
cannot build derivation '/nix/store/hqr53njszabzpqx7y5ybdr0h7cjyhj8a-stdenv-darwin.drv': 35 dependencies couldn't be built
cannot build derivation '/nix/store/0ca4p6skqi685nq24514ydhrjgd7x5lg-perl-5.24.3.drv': 4 dependencies couldn't be built
cannot build derivation '/nix/store/m9z4qsr085rlrjjj1c74zb1k8cq0jy68-openssl-1.0.2o.drv': 3 dependencies couldn't be built
cannot build derivation '/nix/store/85gn4hgbr8brzc6lg135chh2yvz5gvfr-openssl-1.1.0h.drv': 3 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/85gn4hgbr8brzc6lg135chh2yvz5gvfr-openssl-1.1.0h.drv', '/nix/store/m9z4qsr085rlrjjj1c74zb1k8cq0jy68-openssl-1.0.2o.drv' failed

This was referenced Mar 27, 2018
Merged
Merged
@andir andir merged commit 34fe4bc into NixOS:master Mar 27, 2018
@shlevy
Copy link
Member

shlevy commented Mar 28, 2018

@andir Can you draft an announcement to the security list? @grahamc can send it when the update is ready.

@andir
Copy link
Member Author

andir commented Mar 28, 2018

@shlevy I'd love to have that as habit within our security patches process but we haven't done that in ~8 months. There were only three announcements so far (https://github.com/NixOS/security-advisories/tree/master/2017). Unless I am missing something.

Given the relative low severity of the issues addressed within this MR I doubt this is a good candidate to restart that process. On the other hand we must start somewhere :-)

Ideally, if we decide to have announcements again, we should put the required information into the PR or (even better IMO) into the commit messages. Some tooling to pre-fill such an announcement would be nice. We should include commit hashes and some information about that status in the relevant release channel (if available yet).

The announcement then would be a (concatenated) list of commit message +/- some header & footer.

We should probably have some common sense (not strictly a policy in some kind of RFC…) about which branches warrant security announcements. Most distributions stick to stable releases. Announcing everything that has been fixed on master might come across as spam.

My reply is becoming off-topic in here… Feel free to hit me on IRC (andi-) if you want to discuss this further.

@andir andir deleted the openssl branch March 28, 2018 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @GrahamcOfBorg @shlevy