Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcachefs-tools: Changed install flag from PREFIX to DESTDIR, deleted unneeded Makefile #37954

Closed
wants to merge 1 commit into from
Closed

bcachefs-tools: Changed install flag from PREFIX to DESTDIR, deleted unneeded Makefile #37954

wants to merge 1 commit into from

Conversation

Chiiruno
Copy link
Contributor

Motivation for this change

As per @wmertens comments in #37905

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Mar 28, 2018

I don't think this is what we want:

[nix-shell:~/git/nixpkgs]$ find /nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/etc
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/etc/initramfs-tools
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/etc/initramfs-tools/hooks
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/etc/initramfs-tools/hooks/bcachefs
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/etc/initramfs-tools/scripts
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/etc/initramfs-tools/scripts/local-premount
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/etc/initramfs-tools/scripts/local-premount/bcachefs
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr/local
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr/local/share
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr/local/share/man
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr/local/share/man/man8
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr/local/share/man/man8/bcachefs.8
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr/local/sbin
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr/local/sbin/bcachefs
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr/local/sbin/mkfs.bcachefs
/nix/store/nraz5llxz6d7c4z6fca4gjb55br1fl1z-bcachefs-tools-unstable-2018-03-20/usr/local/sbin/fsck.bcachefs

usr/local/sbin is not added to PATH.

@Chiiruno
Copy link
Contributor Author

@Mic92 Whoops. It compiled and installed fine so I thought this was the answer.
Sorry, I'll close until I find a better solution.

@Chiiruno Chiiruno closed this Mar 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Chiiruno @Mic92 @GrahamcOfBorg @Madouura