nixos/version: fix nixops pre 1.6 compatibility #37955
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We should be able to deploy a NixOS 18.03 system with the current nixops stable release. Some options were renamed, so instead of `mkRenamedOptionModule` we introduce them as read-only interal options that won't be rendered in the manual. Only the options that are needed to make nixops evaluations succeed were added. This commit should probably be reverted after or before the 18.09 release, depending on the nixops 1.6 release. The user will not get the warning that these have been renamed but this change is mentioned in the release notes. Fixes NixOS#34253.
Mic92
approved these changes
Mar 28, 2018
globin
approved these changes
Mar 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should be able to deploy a NixOS 18.03 system with the current nixops stable release. Some options were renamed, so instead of
mkRenamedOptionModulewe introduce them as read-only interal options that won't be rendered in the manual.Only the options that are needed to make nixops evaluations succeed were added.
This commit should probably be reverted after or before the 18.09 release, depending on the nixops 1.6 release.
The user will not get the warning that these have been renamed but this change is mentioned in the release notes.
Fixes #34253.
cc @vcunat