pythonPackages.mrbob: fix build #37950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotlambda
requested changes
Mar 30, 2018
| ''; | ||
|
|
||
| propagatedBuildInputs = [ argparse jinja2 six ] | ||
| ++ (lib.optionals isPy26 [ importlib ordereddict ]); |
There was a problem hiding this comment.
This line can be dropped as Python 2.6 is no longer supported.
| sha256 = "6737eaf98aaeae85e07ebef844ee5156df2f06a8b28d7c3dcb056f811c588121"; | ||
| }; | ||
|
|
||
| buildInputs = [ glibcLocales mock ]; |
| ++ (lib.optionals isPy26 [ importlib ordereddict ]); | ||
|
|
||
| meta = with stdenv.lib; { | ||
| homepage = https://github.com/domenkozar/mr.bob.git; |
Tests broke on Hydra as the `checkPhase` wasn't configured properly. By explicitly relying on `nosetests` and injecting `LC_ALL` into the `checkPhase` the tests work again. The license (bsd3) according to `LICENSE` distributed with the upstream package wasn't specified in the meta section which could've caused legal issues. The expression has been moved into its own file to reduce the length and complexity of `pkgs/top-level/python-packages.nix`. See https://hydra.nixos.org/build/70689499/log See NixOS#36453
|
@dotlambda fine now? |
|
@Ma27 Thanks for fixing so much stuff! |
|
Backported in cde1f31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tests broke on Hydra as the
checkPhasewasn't configured properly. Byexplicitly relying on
nosetestsand injectingLC_ALLinto thecheckPhasethe tests work again.The license (bsd3) according to
LICENSEdistributed with the upstreampackage wasn't specified in the meta section which could've caused legal
issues.
The expression has been moved into its own file to reduce the length and
complexity of
pkgs/top-level/python-packages.nix.See https://hydra.nixos.org/build/70689499/log
See #36453
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)