{erlang,elixir}/generic-builder: /bin/sh fixes #37946
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LnL7
reviewed
Mar 27, 2018
| @@ -66,6 +66,8 @@ in stdenv.mkDerivation ({ | |||
|
|
|||
| postPatch = '' | |||
| patchShebangs make | |||
| substituteInPlace erts/etc/unix/Install.src \ | |||
| --replace "#!/bin/sh" "${stdenv.shell}" | |||
There was a problem hiding this comment.
is the #! dropped here intentional?
There was a problem hiding this comment.
Oh my.. Changed the match to be more precise and didn't update the replacement.. Thank you for catching this!
|
If there still are hydra builders with the crap /bin/sh, the right thing is to complain more to get the hydra fixed. Otherwise this is still broken on 17.09 for instance. |
Certain Nix versions used to provide a very feature limited shell as the sandbox /bin/sh. When built in such an environment erlang build would succeed however the resulting package would lack few .boot files. This would result in build failures of erlang projects when built with such a package. The boot files are supposed to be included in the erlang package by being installed with the Install script, however the usage of certain glob patterns not supported by the sandbox /bin/sh and not aborting on errors would cause them to be missing. As such Nix versions may still be out in the wild, including Hydra builders, we patch the source of the Install script to use stdenv's shell rather than relying on any particular feature set of the sandbox /bin/sh. For an example build of erlang where the issue can be seen visit https://hydra.nixos.org/build/70845721/log -> CTRL-F "cp: cannot stat". See also: - #36853 - #36823 - #37638
Certain Nix versions used to provide a very feature limited shell as the sandbox /bin/sh. When built in such an environment elixir build would fail due to usage of certain glob patterns not supported by the sandbox /bin/sh in bin/elixir. As such Nix versions may still be out in the wild, including Hydra builders, we patch bin/elixir to avoid reliance on any particular feature set of the sandbox /bin/sh.
|
As far as I can tell this is no longer needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See commit messages.
buildRubyGem#36853I would propose backporting to 18.03.
nixStable2obtained from nixpkgs @c5f141f (from before backports of
/bin/shfixes).Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)