Revert "Require real path" #5117
Merged
+0
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisBr
added a commit
to ChrisBr/jruby
that referenced
this pull request
Mar 27, 2018
expand load paths to real paths to get rid of duplicate loading from symbolic-linked directories. [Feature #10222] ruby/ruby@b6d3927 This fixes test/mri/ruby/test_require.rb#test_symlink_load_path Deletes obsolete spec/regression/GH-1940_symlink_load_path_should_not_expand_in_FILE_spec.rb jruby#5109 jruby#5117
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #5109
I believe this broke some tests that depend on it not traversing symlinks, such as here: https://travis-ci.org/jruby/jruby/jobs/359034412
@ChrisBr I am about to merge 2.5 to master, so if you want to take another crack at this, base your PR on master.