Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bcal: 1.7 -> 1.8 #36873

Merged
merged 1 commit into from
Mar 12, 2018
Merged

bcal: 1.7 -> 1.8 #36873

merged 1 commit into from
Mar 12, 2018
+5 −8

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update which fixes the build on Darwin and should now work on AArch64 as well.

The tests failed for a good reason on Darwin and should not have been disabled in #36581. The issue has been resolved upstream with version 1.8.

See also #36454 for ZHF.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @matthewbauer

@jfrankenau
bcal: 1.7 -> 1.8
59cc47d 
The tests failed for a good reason on Darwin and should not have been
disabled. The issue has been resolved upstream with version 1.8 which
now also supports AArch64.
@LnL7
Copy link
Member

LnL7 commented Mar 12, 2018

@GrahamcOfBorg build bcal

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: bcal

Partial log (click to expand)

gzip -c bcal.1 > bcal.1.gz
install -m 0644 bcal.1.gz /nix/store/x1swig4ap7yb0hc17y84rprhnkjvdbmm-bcal-1.8/share/man/man1
install -m 0644 README.md /nix/store/x1swig4ap7yb0hc17y84rprhnkjvdbmm-bcal-1.8/share/doc/bcal
rm -f bcal.1.gz
post-installation fixup
gzipping man pages under /nix/store/x1swig4ap7yb0hc17y84rprhnkjvdbmm-bcal-1.8/share/man/
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/x1swig4ap7yb0hc17y84rprhnkjvdbmm-bcal-1.8/bin
patching script interpreter paths in /nix/store/x1swig4ap7yb0hc17y84rprhnkjvdbmm-bcal-1.8
/nix/store/x1swig4ap7yb0hc17y84rprhnkjvdbmm-bcal-1.8

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: bcal

Partial log (click to expand)

rm -f bcal.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/vs2fgv07m42zbzpj3hifk1h5f4sf5qrg-bcal-1.8
shrinking /nix/store/vs2fgv07m42zbzpj3hifk1h5f4sf5qrg-bcal-1.8/bin/bcal
gzipping man pages under /nix/store/vs2fgv07m42zbzpj3hifk1h5f4sf5qrg-bcal-1.8/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/vs2fgv07m42zbzpj3hifk1h5f4sf5qrg-bcal-1.8/bin 
patching script interpreter paths in /nix/store/vs2fgv07m42zbzpj3hifk1h5f4sf5qrg-bcal-1.8
checking for references to /tmp/nix-build-bcal-1.8.drv-0 in /nix/store/vs2fgv07m42zbzpj3hifk1h5f4sf5qrg-bcal-1.8...
/nix/store/vs2fgv07m42zbzpj3hifk1h5f4sf5qrg-bcal-1.8

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: bcal

Partial log (click to expand)

rm -f bcal.1.gz
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9lmyk1d5bfx2bs95888q797a26mqznxv-bcal-1.8
shrinking /nix/store/9lmyk1d5bfx2bs95888q797a26mqznxv-bcal-1.8/bin/bcal
gzipping man pages under /nix/store/9lmyk1d5bfx2bs95888q797a26mqznxv-bcal-1.8/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9lmyk1d5bfx2bs95888q797a26mqznxv-bcal-1.8/bin
patching script interpreter paths in /nix/store/9lmyk1d5bfx2bs95888q797a26mqznxv-bcal-1.8
checking for references to /build in /nix/store/9lmyk1d5bfx2bs95888q797a26mqznxv-bcal-1.8...
/nix/store/9lmyk1d5bfx2bs95888q797a26mqznxv-bcal-1.8

LnL7
LnL7 approved these changes Mar 12, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@LnL7 LnL7 merged commit a6bf2b2 into NixOS:master Mar 12, 2018
@jfrankenau jfrankenau deleted the update-bcal branch March 12, 2018 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jfrankenau @LnL7 @GrahamcOfBorg