Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kde-frameworks: 5.43 -> 5.44 #36868

Merged
merged 1 commit into from Mar 20, 2018
Merged

kde-frameworks: 5.43 -> 5.44 #36868

merged 1 commit into from Mar 20, 2018

Conversation

bkchr
Copy link
Contributor

@bkchr bkchr commented Mar 12, 2018 •
edited

Motivation for this change

I could not run nox-reviewas it always crash (the error was something with the garbage collector of nix) :(

@ttuegel @adisbladis @peterhoeg

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bkchr bkchr requested a review from ttuegel as a code owner March 12, 2018 16:39
@ttuegel
Copy link
Member

ttuegel commented Mar 17, 2018

Any idea why this wants to rebuild so many packages on Linux?

@bkchr
Copy link
Contributor Author

bkchr commented Mar 17, 2018

No sorry.

ttuegel
ttuegel approved these changes Mar 20, 2018
View reviewed changes
Copy link
Member

@ttuegel ttuegel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ttuegel ttuegel merged commit 4590309 into NixOS:master Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel ttuegel approved these changes

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bkchr @ttuegel @GrahamcOfBorg