Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sambaMaster: 4.8.0_2018-01-25 -> 2018-03-09 #36874

Merged
merged 1 commit into from
Mar 13, 2018
Merged

sambaMaster: 4.8.0_2018-01-25 -> 2018-03-09 #36874

merged 1 commit into from
Mar 13, 2018
+4 −4

Conversation

lukeadams
Copy link
Contributor

Motivation for this change

Bring sambaMaster up to 4.8-rc4 to enable testing for 4.8 stable release. Samba test ran by overriding samba with sambaMaster, which passed.

Not sure if the _ is the preferred naming scheme for evergreen packages... Let me know if a different style is preferred.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 12, 2018
@fpletz
Copy link
Member

fpletz commented Mar 12, 2018

This version scheme is currently broken and won't work with nix-env.

See https://nixos.org/nixpkgs/manual/#sec-package-naming:

If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".

@lukeadams lukeadams force-pushed the sambaMaster-update branch 2 times, most recently from 231c257 to ceb094c Compare March 12, 2018 22:30
@lukeadams lukeadams force-pushed the sambaMaster-update branch from ceb094c to da45e8d Compare March 12, 2018 22:32
@lukeadams lukeadams changed the title sambaMaster: 4.8.0_2018-01-25 -> 4.8.0_2018-03-09 sambaMaster: 4.8.0_2018-01-25 -> 2018-03-09 Mar 13, 2018
@lukeadams
Copy link
Contributor Author

Ahh, I missed that part of the manual. Should be good now.

@fpletz
Copy link
Member

fpletz commented Mar 13, 2018

@GrahamcOfBorg build sambaMaster

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: sambaMaster

No log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: sambaMaster

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/zr7ar17yb2k0d0d70vqplc632ayfs5sf-samba-unstable-2018-03-09-dev
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/zr7ar17yb2k0d0d70vqplc632ayfs5sf-samba-unstable-2018-03-09-dev/lib
patching script interpreter paths in /nix/store/zr7ar17yb2k0d0d70vqplc632ayfs5sf-samba-unstable-2018-03-09-dev
checking for references to /build in /nix/store/zr7ar17yb2k0d0d70vqplc632ayfs5sf-samba-unstable-2018-03-09-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/7pabd9rn0niksgmhmc5gjqnhyc7n2mms-samba-unstable-2018-03-09-man
gzipping man pages under /nix/store/7pabd9rn0niksgmhmc5gjqnhyc7n2mms-samba-unstable-2018-03-09-man/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/7pabd9rn0niksgmhmc5gjqnhyc7n2mms-samba-unstable-2018-03-09-man
checking for references to /build in /nix/store/7pabd9rn0niksgmhmc5gjqnhyc7n2mms-samba-unstable-2018-03-09-man...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: sambaMaster

Partial log (click to expand)

strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/fyfa1iwyfdsgdrhk4lvmxn6zz0blszib-samba-unstable-2018-03-09-dev/lib
patching script interpreter paths in /nix/store/fyfa1iwyfdsgdrhk4lvmxn6zz0blszib-samba-unstable-2018-03-09-dev
checking for references to /build in /nix/store/fyfa1iwyfdsgdrhk4lvmxn6zz0blszib-samba-unstable-2018-03-09-dev...
shrinking RPATHs of ELF executables and libraries in /nix/store/0r8lfzvayds4fl1vr3z394ggshs82xwm-samba-unstable-2018-03-09-man
gzipping man pages under /nix/store/0r8lfzvayds4fl1vr3z394ggshs82xwm-samba-unstable-2018-03-09-man/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/0r8lfzvayds4fl1vr3z394ggshs82xwm-samba-unstable-2018-03-09-man
checking for references to /build in /nix/store/0r8lfzvayds4fl1vr3z394ggshs82xwm-samba-unstable-2018-03-09-man...
/nix/store/xga46fp6ia6p1ilk3jr16lcrv53aa5rg-samba-unstable-2018-03-09

@fpletz fpletz merged commit b6990ed into NixOS:master Mar 13, 2018
@lukeadams lukeadams deleted the sambaMaster-update branch May 26, 2021 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukeadams @fpletz @GrahamcOfBorg