Disable background thread when networking is off #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI, this timed out on pycicle so I'll take this as an opportunity to check what breaks with networking off (or what tests etc. should be disabled, if they're not already disabled). Consider this low-priority exploration. |
|
@msimberg Thanks! And yes, tests will be a problem - we never really made this consistent. |
The flag can still be set but has no effect.
…elevant options in hpxrun.py Force one locality for all tests with more than one locality and don't pass localities and parcelport options on from hpxrun.py to the test executable (since the options are disabled and cause the test to fail).
msimberg
force-pushed
the
no-background-thread-networking-off
branch
from
6ee8cad
to
9a62c15
Compare
msimberg
force-pushed
the
no-background-thread-networking-off
branch
2 times, most recently
from
d47a3ea
to
d712398
Compare
msimberg
force-pushed
the
no-background-thread-networking-off
branch
from
a43e95b
to
b2ebc9d
Compare
|
This ran successfully with I've
|
msimberg
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
scheduling_loopifHPX_HAVE_NETWORKING=OFF@biddisco Might give you a tiny speedup for Cholesky, unless you've already disabled the background thread.
WIP as I will still run the tests with pycicle and networking off.