Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gitea: 1.3.2 -> 1.3.3 #36812

Merged
merged 1 commit into from Mar 13, 2018
Merged

gitea: 1.3.2 -> 1.3.3 #36812

merged 1 commit into from Mar 13, 2018

Conversation

jfrankenau
Copy link
Member

Motivation for this change

Update with two backported security fixes. Would be good to have it on 18.03(-beta) as well.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @disassembler @afldcr

@grahamc
Copy link
Member

grahamc commented Mar 12, 2018

@GrahamcOfBorg build gitea

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: gitea

Partial log (click to expand)

checking for references to /build in /nix/store/0npk40qqakam135xrlj4a4fdv8fjjyki-gitea-1.3.3-bin...
shrinking RPATHs of ELF executables and libraries in /nix/store/67df389vin1c0qclnby8bp3nz5446zn5-gitea-1.3.3
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/67df389vin1c0qclnby8bp3nz5446zn5-gitea-1.3.3
checking for references to /build in /nix/store/67df389vin1c0qclnby8bp3nz5446zn5-gitea-1.3.3...
shrinking RPATHs of ELF executables and libraries in /nix/store/7ibn7xjvfijjfqg5ps1djiiwi407r36k-gitea-1.3.3-data
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/7ibn7xjvfijjfqg5ps1djiiwi407r36k-gitea-1.3.3-data
checking for references to /build in /nix/store/7ibn7xjvfijjfqg5ps1djiiwi407r36k-gitea-1.3.3-data...
/nix/store/0npk40qqakam135xrlj4a4fdv8fjjyki-gitea-1.3.3-bin

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: gitea

Partial log (click to expand)

/private/tmp/nix-build-gitea-1.3.3.drv-0
post-installation fixup
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/qs5z5q2hg8mhqxxjhxshfh48d7cw3m41-gitea-1.3.3-bin/bin
patching script interpreter paths in /nix/store/qs5z5q2hg8mhqxxjhxshfh48d7cw3m41-gitea-1.3.3-bin
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/hwdv1w27p58211gvys3qin33mib3xasb-gitea-1.3.3
strip is /nix/store/4sdh09gmvl15cy0zb6i7mbvxh5syz206-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/3j4hs4a2fm39d3i6p0l22zqhq05m385p-gitea-1.3.3-data
/nix/store/qs5z5q2hg8mhqxxjhxshfh48d7cw3m41-gitea-1.3.3-bin

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: gitea

Partial log (click to expand)

code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/search/highlight/highlighter/html
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/index/upsidedown
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/analysis/tokenizer/unicode
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/analysis/lang/en
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/analysis/analyzer/standard
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/mapping
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve/search/query
code.gitea.io/gitea/vendor/github.com/blevesearch/bleve
builder for '/nix/store/4jxzmnhr8vxh32fw3hszgqz451b6cffa-gitea-1.3.3.drv' failed with exit code 42
�[31;1merror:�[0m build of '/nix/store/4jxzmnhr8vxh32fw3hszgqz451b6cffa-gitea-1.3.3.drv' failed

@afldcr
Copy link
Contributor

afldcr commented Mar 12, 2018

Looks good to me, thanks for doing this!

I cant tell what those build failures are though; those look like successful builds.

@disassembler
Copy link
Member

I'll merge and cherry pick to 18.03 tonight.

@disassembler disassembler merged commit 1077e01 into NixOS:master Mar 13, 2018
@disassembler
Copy link
Member

Merged and cherry picked to 18.03! Thanks for updating this!

@jfrankenau jfrankenau deleted the update-gitea branch March 13, 2018 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@disassembler disassembler disassembler approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jfrankenau @grahamc @GrahamcOfBorg @afldcr @disassembler