Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bitcoin-unlimited: fix build with boost 1.66 #36835

Merged
merged 1 commit into from Mar 12, 2018
Merged

bitcoin-unlimited: fix build with boost 1.66 #36835

merged 1 commit into from Mar 12, 2018

Conversation

YorikSar
Copy link
Contributor

Use part of fix for mainline bitcoin:
bitcoin/bitcoin@1ec0c0a

Also enable parallel builds for speed.

Motivation for this change

It was failing in Hydra: release-18.03/nixpkgs.altcoins.bitcoin-unlimited.x86_64-linux
/cc ZHF #36453

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@YorikSar
bitcoin-unlimited: fix build with boost 1.66
876420f 
Use part of fix for mainline bitcoin:
bitcoin/bitcoin@1ec0c0a

Also enable parallel builds for speed.
@fpletz
Copy link
Member

fpletz commented Mar 12, 2018

@GrahamcOfBorg build altcoins.bitcoin-unlimited

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: altcoins.bitcoin-unlimited

No log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: altcoins.bitcoin-unlimited

Partial log (click to expand)

shrinking /nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0/bin/bitcoin-cli
shrinking /nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0/bin/bench_bitcoin
shrinking /nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0/bin/bitcoin-qt
shrinking /nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0/bin/test_bitcoin
shrinking /nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0/lib/libbitcoinconsensus.so.0.0.0
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0/lib  /nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0/bin 
patching script interpreter paths in /nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0
checking for references to /tmp/nix-build-bitcoin-unlimited-1.0.2.0.drv-0 in /nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0...
/nix/store/hdzjsw7p4cf6c41ks2y0r5dvkh5w0r2r-bitcoin-unlimited-1.0.2.0

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: altcoins.bitcoin-unlimited

Partial log (click to expand)

shrinking /nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0/bin/test_bitcoin
shrinking /nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0/bin/bitcoin-tx
shrinking /nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0/bin/bitcoin-cli
shrinking /nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0/bin/bitcoind
shrinking /nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0/lib/libbitcoinconsensus.so.0.0.0
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0/lib  /nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0/bin
patching script interpreter paths in /nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0
checking for references to /build in /nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0...
/nix/store/7nqd9rk6565w49sfrn17lz3vfd2d87sj-bitcoin-unlimited-1.0.2.0

@fpletz fpletz merged commit c26f960 into NixOS:master Mar 12, 2018
@fpletz fpletz mentioned this pull request Mar 13, 2018
Merged
@YorikSar YorikSar deleted the fix-bitcoin-unlimited branch March 15, 2018 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@YorikSar @fpletz @GrahamcOfBorg