qtkeychain: 0.7.0 -> 0.8.0, fix darwin build #36834
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
| ++ stdenv.lib.optional stdenv.isDarwin [ | ||
| # correctly detect the compiler | ||
| # for details see cmake --help-policy CMP0025 | ||
| "-DCMAKE_POLICY_DEFAULT_CMP0025=NEW" |
There was a problem hiding this comment.
Would it make sense to set this globally? I think this is the behavior we always want but it might not make a difference for most CMake projects.
There was a problem hiding this comment.
I think so. At the least setting CMAKE_POLICY_WARNING_CMP0025 would be helpful for identifying this issue in other packages.
There was a problem hiding this comment.
Thanks! See #37015 for the PR making this the default.
There was a problem hiding this comment.
So after doing this, we still occasionally get issues like in:
https://hydra.nixos.org/build/73579953/nixlog/1
Any ideas how to fix it?
|
@GrahamcOfBorg build qtkeychain |
|
Success on x86_64-darwin (full log) Attempted: qtkeychain Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: qtkeychain Partial log (click to expand)
|
LnL7
reviewed
Mar 12, 2018
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "qtkeychain-${if withQt5 then "qt5" else "qt4"}-${version}"; | ||
| version = "0.7.0"; |
There was a problem hiding this comment.
Hmm, is 0.7.0 and 0.8.0 the same revision?
There was a problem hiding this comment.
Right, the unchanged hash is a mistake, apparently.
There was a problem hiding this comment.
Thing is I tested both versions with --check and neither gives a hash mismatch
There was a problem hiding this comment.
Yea I overlooked changing sha256. I was seeing some odd behavior though: changing sha256 controlled the version build, regardless of the value of rev, but it seems that a nix-collect-garbage may work around this.
- set correct
revandsha256(egv0.6.0and0sbgy1vxabcnn1qi9dfxi6yd0gbbqfgx7sj0c381mp4xay9fxl21) nix-build -A qtkeychain(successfully builds)- built version is
0.6.0(set(PACKAGE_VERSION "0.6.0")inresult/lib/cmake/QtKeychain/QtKeychainConfigVersion.cmake) - fudge the
revbut keepsha256(egrev -> v0.8.0) nix-build -A qtkeychain(successfully builds)- built version is still
0.6.0
I'll set the correct hash
There was a problem hiding this comment.
Fetches are hash-addressed ("fixed-output" in our terminology). If you have the specified hash in nix store, it will be used without any further checks.
There was a problem hiding this comment.
Ahhh :) I understand now, thanks!
There was a problem hiding this comment.
You can force a check with nix-build '<nixpkgs>' -A hello.src --check for example.
|
Failure on aarch64-linux (full log) Attempted: qtkeychain Partial log (click to expand)
|
The darwin build was failing for two reasons 1) cmake incorrectly detected the compiler 2) missing Frameworks /cc ZHF NixOS#36454
|
@GrahamcOfBorg build qtkeychain |
|
btw, tomahawk (which depends on this) fails due to not finding qtkeychain 0.8.0, but it is abandoned (tomahawk-player/tomahawk@c838959). |
|
@GrahamcOfBorg build qtkeychain |
|
Success on x86_64-linux (full log) Attempted: qtkeychain Partial log (click to expand)
|
|
Failure on x86_64-darwin (full log) Attempted: qtkeychain Partial log (click to expand)
|
|
Failure on aarch64-linux (full log) Attempted: qtkeychain Partial log (click to expand)
|
|
This broke the build of |
|
Okay opened issue: #37746 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The darwin build was failing for two reasons
/cc ZHF #36454
Also related to #35444
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"this passes on NixOS but there are (still) failures on Darwin./result/bin/)