Add guidelines and instructions for porting to React #628
+80
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mwiencek
reviewed
Mar 12, 2018
HACKING.md
Outdated
| ``` | ||
| where the `convert_to_json` is a function that converts `prop_val` to its appropriate | ||
| JSON representation. If `prop_val` is an entity that has a `TO_JSON` sub defined, it will | ||
| most probably be called by the Server and you can simply pass `prop_val`. |
There was a problem hiding this comment.
We should probably remove "most probably" since it should be called, and that makes it sounds more mysterious than it is. :P
mwiencek
reviewed
Mar 12, 2018
HACKING.md
Outdated
| [%~ React.embed(c, 'relative/path/to/component/from/root', { prop_name => prop_val }) ~%] | ||
| ``` | ||
| 3. You can access the CatalystContext via the variable `$c`. | ||
| 4. To communicate between Perl and Node Server(which renders React components for us), you need to |
There was a problem hiding this comment.
"between the Perl and Node servers (which" (+space after servers)
mwiencek
reviewed
Mar 12, 2018
HACKING.md
Outdated
| * All components must be type-annotated. We use flow for static type checks. You can find more | ||
| about it at [flow docs](https://flow.org/en/docs/). | ||
| * Global types are defined in `root/types.js`. They can be used without imports. | ||
| * Make sure your JS files conform to our ESlint setup. |
There was a problem hiding this comment.
Not sure we explain how to run eslint anywhere yet either.
|
This looks very good. 👍 |
mwiencek
approved these changes
Mar 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.