Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.shapely: fix darwin build #36837

Merged
merged 1 commit into from Mar 12, 2018
Merged

pythonPackages.shapely: fix darwin build #36837

merged 1 commit into from Mar 12, 2018

Conversation

knedlsepp
Copy link
Member

Motivation for this change

18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@knedlsepp knedlsepp requested a review from FRidh as a code owner March 12, 2018 00:49
@FRidh
Copy link
Member

FRidh commented Mar 12, 2018

@GrahamcOfBorg build pythonPackages.shapely

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: pythonPackages.shapely

Partial log (click to expand)

tests/test_xy.py ..                                                      [100%]

=============================== warnings summary ===============================
tests/test_linestring.py:160
  assertion is always true, perhaps remove parentheses?

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================= 13 tests deselected ==============================
============ 251 passed, 13 deselected, 1 warnings in 1.46 seconds =============
/nix/store/236gqlkrbia9a9k1ykijzcx0gcw62jvl-python2.7-Shapely-1.6.4.post1

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pythonPackages.shapely

Partial log (click to expand)

tests/test_xy.py ..                                                      [100%]

=============================== warnings summary ===============================
tests/test_linestring.py:160
  assertion is always true, perhaps remove parentheses?

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================= 13 tests deselected ==============================
============ 251 passed, 13 deselected, 1 warnings in 6.32 seconds =============
/nix/store/zxf1nkamfsp1i3n186n5zn60sjfyj59z-python2.7-Shapely-1.6.4.post1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pythonPackages.shapely

Partial log (click to expand)

tests/test_xy.py ..                                                      [100%]

=============================== warnings summary ===============================
tests/test_linestring.py:160
  assertion is always true, perhaps remove parentheses?

-- Docs: http://doc.pytest.org/en/latest/warnings.html
============================= 13 tests deselected ==============================
============ 251 passed, 13 deselected, 1 warnings in 9.07 seconds =============
/nix/store/qrmjnsqj4mfq3kvwyqyl1nifzidvxdfm-python2.7-Shapely-1.6.4.post1

@LnL7 LnL7 merged commit 9055cb8 into NixOS:master Mar 12, 2018
@knedlsepp knedlsepp deleted the fix-pythonPackages.shapely-on-darwin branch March 12, 2018 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@knedlsepp @FRidh @GrahamcOfBorg @LnL7