Semantic: add bindings for Union and ProcNotation #5807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion Fixed crystal-lang#5805 The reason of crystal-lang#5805 is missing to check untyped in union types. And `ProcNotation` has the same problem. It is fixed also.
makenowjust
force-pushed
the
fix/crystal/ealry-return-for-untyped-union-and-proc-type
branch
from
195cf68
to
4cdf33e
Compare
|
I pushed a new commit. See this weird result. I fixed this in the new commit. def foo
a = 1
loop do
b = [] of typeof(a)
p typeof(b)
a = "hello"
break
end
end
def bar
a = 1
loop do
b = [] of typeof(a) | Int32 # <- use union type instead bare typeof
p typeof(b)
a = "hello"
break
end
end
foo # prints "Array(Int32 | String)"
bar # prints "Array(Int32)" !!?This issue is little far from #5805, however the solution for this also fixes #5805 surely, so I pushed into this PR. I'll fix PR title. |
makenowjust
changed the title
|
@makenowjust Do you think this would also fix issue #5717? I'm getting the following error since 0.24.1:
|
straight-shoota
added
the
pr:needs-work
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #5805
The reason of #5805 is missing to check untyped in union types.
And
ProcNotationhas the same problem. It is fixed also.