Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: pythonPackages.macfsevents: init at 0.8.1 #36825

Closed
wants to merge 1 commit into from
Closed

WIP: pythonPackages.macfsevents: init at 0.8.1 #36825

wants to merge 1 commit into from
+25 −0

Conversation

knedlsepp
Copy link
Member

@knedlsepp knedlsepp commented Mar 11, 2018 •
edited
Loading

Motivation for this change

This adds macfsevents in order to fix #32087. This new package is required to fix pynotify on darwin.

Caveat

As of now this is still WIP, because during the checkPhase, I get a segmentation fault:

test_existing_directories_are_not_reported (tests.FileObservationTestCase) ... /nix/store/0igxxngigjgfkgg3cw547n92b8bpg6b1-stdenv-darwin/setup: line 1230: 45926 Segmentation fault: 11  /nix/store/4llw0i5jbb7p5n0r58w9z0azqgx5wk09-python-2.7.14/bin/python2.7 nix_run_setup test

Maybe someone could give me some pointers on how to proceed.
I guess this has something to do with the darwin headers on nixpkgs not actually matching the kernel version. (I'm on OS 10.11.6)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@knedlsepp knedlsepp requested a review from FRidh as a code owner March 11, 2018 19:55
@knedlsepp
Copy link
Member Author

@LnL7 Do you have any tips on how to diagnose the segmentation fault for this darwin package?

@GrahamcOfBorg GrahamcOfBorg added 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 11, 2018
@LnL7
Copy link
Member

LnL7 commented Mar 11, 2018 •
edited
Loading

Yes, python packages that depend on frameworks still suffer from #12346, #31865. Sadly interpreters need DYLD_FRAMEWORK_PATH as a workaround, both for tests like this case and in the final wrapper of the command that depends on it.

DYLD_FRAMEWORK_PATH=/System/Library/Frameworks

@matthewbauer matthewbauer added the 2.status: work-in-progress This PR isn't done label Mar 22, 2018
@FRidh
Copy link
Member

FRidh commented May 13, 2018

Status?

@knedlsepp
Copy link
Member Author

There's still the problem with the whole macOS frameworks don't work properly with python issue. I have no idea how to properly solve this except wrapping all downstream applications, which is somewhat ugly. I guess, I'm closing this for now.

@knedlsepp knedlsepp closed this May 13, 2018
@FRidh
Copy link
Member

FRidh commented May 13, 2018 

makeWrapperArgs = [ "--set DYLD_FRAMEWORK_PATH /System/Library/Frameworks" ]

If this applies to all Darwin packages we may as well add it to the builder.

@knedlsepp
Copy link
Member Author

I don't know why this is difficult, but the linked issue has the following comment #12346 (comment)

@oyren oyren mentioned this pull request Aug 4, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh

Assignees
No one assigned
Labels
2.status: work-in-progress This PR isn't done 6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

nikola don't build on darwin
5 participants
@knedlsepp @LnL7 @FRidh @matthewbauer @GrahamcOfBorg