Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud-client: restrict platform to linux #36788

Merged
merged 1 commit into from Mar 14, 2018

Conversation

badmutex
Copy link
Contributor

Motivation for this change

/cc ZHF #36454

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@bjornfor
Copy link
Contributor

Can you write a line in the commit message why we should restrict nextcloud-client to linux? (Like "nextcloud-client does not support darwin", or something like that?)

@badmutex
Copy link
Contributor Author

There are some underlying dependencies failing. qtkeychain was one (fix in #36834), but there are others.
I'll update the message to reflect this.

Some dependencies fail to build on darwin.
@badmutex badmutex force-pushed the darwin-fixes-nextcloud-client branch from 7f548e0 to b619881 Compare March 12, 2018 00:09
@badmutex badmutex mentioned this pull request Mar 12, 2018
8 tasks
@vcunat
Copy link
Member

vcunat commented Mar 14, 2018

/cc maintainer @caugner.

vcunat added a commit that referenced this pull request Mar 14, 2018
coreyoconnor pushed a commit to coreyoconnor/nixpkgs that referenced this pull request Mar 14, 2018
@vcunat vcunat merged commit b619881 into NixOS:master Mar 14, 2018
@badmutex badmutex deleted the darwin-fixes-nextcloud-client branch March 18, 2018 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants