Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fcgiwrap: don't error on implicit fallthrough #36807

Merged
merged 1 commit into from Mar 12, 2018
Merged

fcgiwrap: don't error on implicit fallthrough #36807

merged 1 commit into from Mar 12, 2018

Conversation

tilpner
Copy link
Member

@tilpner tilpner commented Mar 11, 2018

Motivation for this change

This errored since ca8aa5d, but should be safe.
Warning is left on (instead of completely disabled),
to not hide potential other fallthroughs if someone
was to make changes to fcgiwrap with this package.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

cc @lethalman, ping #31747

@tilpner
fcgiwrap: don't error on implicit fallthrough
a758ae4 
This errored since ca8aa5d, but should be safe.
Warning is left on (instead of completely disabled),
to not hide potential other fallthroughs if someone
was to make changes to fcgiwrap with this package.
@vcunat
Copy link
Member

vcunat commented Mar 12, 2018

@GrahamcOfBorg build fcgiwrap

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: fcgiwrap

No log is available.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: fcgiwrap

Partial log (click to expand)

moving /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0/man to /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0
shrinking /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0/sbin/fcgiwrap
gzipping man pages under /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0/share/man/
strip is /nix/store/b0zlxla7dmy1iwc3g459rjznx59797xy-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0/sbin
patching script interpreter paths in /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0
checking for references to /build in /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0...
moving /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0/sbin/* to /nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0/bin
/nix/store/akzx76jrh9asclh3b5hji6ly1vagbx6a-fcgiwrap-1.1.0

@vcunat
Copy link
Member

vcunat commented Mar 12, 2018

(waiting for aarch64)

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: fcgiwrap

Partial log (click to expand)

moving /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0/man to /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0/share/man
shrinking RPATHs of ELF executables and libraries in /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0
shrinking /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0/sbin/fcgiwrap
gzipping man pages under /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0/share/man/
strip is /nix/store/lvx1acn1ig1j2km8jds5x3ggh3f2wa8v-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0/sbin
patching script interpreter paths in /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0
checking for references to /build in /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0...
moving /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0/sbin/* to /nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0/bin
/nix/store/93djvpclm9azwxafklfgxcim42q2x6za-fcgiwrap-1.1.0

florianjacob pushed a commit to florianjacob/nixpkgs that referenced this pull request Mar 12, 2018
@vcunat
Merge NixOS#36807: fcgiwrap: avoid failure on warning
b0b1de8
@vcunat vcunat merged commit a758ae4 into NixOS:master Mar 12, 2018
@tilpner tilpner deleted the fcgiwrap-no-error branch March 12, 2018 19:22
vcunat added a commit that referenced this pull request Mar 12, 2018
@vcunat
Merge #36807: fcgiwrap: avoid failure on warning
0092cf6 
(cherry picked from commit b0b1de8)
@vcunat vcunat mentioned this pull request Mar 12, 2018
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tilpner @vcunat @GrahamcOfBorg