Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MINC ecosystem #38664

Merged
merged 24 commits into from Apr 21, 2018
Merged

MINC ecosystem #38664

merged 24 commits into from Apr 21, 2018

Conversation

bcdarwin
Copy link
Member

Motivation for this change

Adds and updates a large set of tools for working with MINC imaging data in several commits, most but not all logically self-contained. Updates the stale #29782.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

@GrahamcOfBorg build ezminc minc_tools mni_autoreg arguments bicpl libminc ants EBTKS c3d elastix perlPackages.TextFormat oobicpl minc_widgets perlPackages.MNI-Perllib itk n3 inormalize

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: arguments, ants, c3d, perlPackages.TextFormat, perlPackages.MNI-Perllib, itk

The following builds were skipped because they don't evaluate on x86_64-darwin: ezminc, minc_tools, mni_autoreg, bicpl, libminc, EBTKS, elastix, oobicpl, minc_widgets, n3, inormalize

Partial log (click to expand)

/nix/store/dv674n45agkisvr2dczn3d12xr0h6aji-ANTs-2.2.0/bin/.antsIntermodalityIntrasubject.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/dv674n45agkisvr2dczn3d12xr0h6aji-ANTs-2.2.0/bin/.antsIntroduction.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/dv674n45agkisvr2dczn3d12xr0h6aji-ANTs-2.2.0/bin/.antsJointLabelFusion.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/dv674n45agkisvr2dczn3d12xr0h6aji-ANTs-2.2.0/bin/.antsLongitudinalCorticalThickness.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/dv674n45agkisvr2dczn3d12xr0h6aji-ANTs-2.2.0/bin/.antsMultivariateTemplateConstruction.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/dv674n45agkisvr2dczn3d12xr0h6aji-ANTs-2.2.0/bin/.antsMultivariateTemplateConstruction2.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/dv674n45agkisvr2dczn3d12xr0h6aji-ANTs-2.2.0/bin/.ANTSpexec.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/dv674n45agkisvr2dczn3d12xr0h6aji-ANTs-2.2.0/bin/.antsRegistrationSyN.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
/nix/store/dv674n45agkisvr2dczn3d12xr0h6aji-ANTs-2.2.0/bin/.antsRegistrationSyNQuick.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/x030a63qdilnv02pkivfjg44pdxsh5km-bash-4.4-p19/bin/bash"
�[31;1merror:�[0m build of '/nix/store/4z2xjx9wfla3v6pyz46043gfg3ziqjsl-c3d-1.1.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: ezminc, minc_tools, mni_autoreg, arguments, bicpl, libminc, ants, EBTKS, c3d, elastix, perlPackages.TextFormat, oobicpl, minc_widgets, perlPackages.MNI-Perllib, itk, n3, inormalize

Partial log (click to expand)

/nix/store/f13ljhg32x9zna76pbvniiixpvklh3kh-mni_autoreg-2017-09-22/bin/autocrop: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/ggb7k5x9855j10dz99467djx4rplg32b-perl-5.24.3/bin/perl"
/nix/store/f13ljhg32x9zna76pbvniiixpvklh3kh-mni_autoreg-2017-09-22/bin/make_model: interpreter directive changed from " /bin/sh" to "/nix/store/q1g0rl8zfmz7r371fp5p42p4acmv297d-bash-4.4-p19/bin/sh"
/nix/store/f13ljhg32x9zna76pbvniiixpvklh3kh-mni_autoreg-2017-09-22/bin/mritoself: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/ggb7k5x9855j10dz99467djx4rplg32b-perl-5.24.3/bin/perl"
/nix/store/f13ljhg32x9zna76pbvniiixpvklh3kh-mni_autoreg-2017-09-22/bin/mritotal: interpreter directive changed from " /usr/bin/env perl" to "/nix/store/ggb7k5x9855j10dz99467djx4rplg32b-perl-5.24.3/bin/perl"
checking for references to /tmp/nix-build-mni_autoreg-2017-09-22.drv-0 in /nix/store/f13ljhg32x9zna76pbvniiixpvklh3kh-mni_autoreg-2017-09-22...
/nix/store/f13ljhg32x9zna76pbvniiixpvklh3kh-mni_autoreg-2017-09-22/bin/autocrop
/nix/store/f13ljhg32x9zna76pbvniiixpvklh3kh-mni_autoreg-2017-09-22/bin/mritoself
/nix/store/f13ljhg32x9zna76pbvniiixpvklh3kh-mni_autoreg-2017-09-22/bin/mritotal
/nix/store/f13ljhg32x9zna76pbvniiixpvklh3kh-mni_autoreg-2017-09-22/bin/xfmtool
error: build of ‘/nix/store/h4i19z6bs65dg7y5aqvs5qfiswwgmx3n-elastix-4.8.drv’, ‘/nix/store/kaslwi6v2i2g2wbsqqpf46q33yw7dsx4-c3d-1.1.0.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: ezminc, minc_tools, mni_autoreg, arguments, bicpl, libminc, ants, EBTKS, c3d, elastix, perlPackages.TextFormat, oobicpl, minc_widgets, perlPackages.MNI-Perllib, itk, n3, inormalize

Partial log (click to expand)

/nix/store/qs64w7d22mjkprdl8k8lq89lxrwd6jfz-ANTs-2.2.0/bin/.antsJointLabelFusion.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/qs64w7d22mjkprdl8k8lq89lxrwd6jfz-ANTs-2.2.0/bin/.antsIntroduction.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/qs64w7d22mjkprdl8k8lq89lxrwd6jfz-ANTs-2.2.0/bin/.antsIntermodalityIntrasubject.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/qs64w7d22mjkprdl8k8lq89lxrwd6jfz-ANTs-2.2.0/bin/.antsCorticalThickness.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/qs64w7d22mjkprdl8k8lq89lxrwd6jfz-ANTs-2.2.0/bin/.antsBrainExtraction.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/qs64w7d22mjkprdl8k8lq89lxrwd6jfz-ANTs-2.2.0/bin/.antsAtroposN4.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/qs64w7d22mjkprdl8k8lq89lxrwd6jfz-ANTs-2.2.0/bin/.antsASLProcessing.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
/nix/store/qs64w7d22mjkprdl8k8lq89lxrwd6jfz-ANTs-2.2.0/bin/.ANTSpexec.sh-wrapped: interpreter directive changed from "/bin/bash" to "/nix/store/3gg2p6n4kv2f0lsxd41f5iz1ivkbzyzr-bash-4.4-p19/bin/bash"
checking for references to /build in /nix/store/qs64w7d22mjkprdl8k8lq89lxrwd6jfz-ANTs-2.2.0...
�[31;1merror:�[0m build of '/nix/store/brzh468q8rdkmr5rg2wz7w67blwmpjha-elastix-4.8.drv', '/nix/store/jhrsdjl8bil6j7p7k5vp2m2lq78r8sz5-c3d-1.1.0.drv' failed

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

c3d fails on all targets.

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

@GrahamcOfBorg build c3d

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Attempted: c3d

Partial log (click to expand)

void ImageToImageFilterDefaultCopyInformation(const typename
     ^
2 errors generated.
make[2]: *** [CMakeFiles/cnd_adapters.dir/build.make:639: CMakeFiles/cnd_adapters.dir/adapters/HessianEigenValues.cxx.o] Error 1
make[2]: *** Waiting for unfinished jobs....
8 warnings generated.
make[1]: *** [CMakeFiles/Makefile2:68: CMakeFiles/cnd_adapters.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/4z2xjx9wfla3v6pyz46043gfg3ziqjsl-c3d-1.1.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/4z2xjx9wfla3v6pyz46043gfg3ziqjsl-c3d-1.1.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Attempted: c3d

Partial log (click to expand)

       ~~~~~~~~~~~~~~~~~
       destImage, srcImage);
       ~~~~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/cnd_adapters.dir/build.make:639: CMakeFiles/cnd_adapters.dir/adapters/HessianEigenValues.cxx.o] Error 1
[ 91%] Linking CXX static library libcnd_driver.a
[ 91%] Built target cnd_driver
make[1]: *** [CMakeFiles/Makefile2:695: CMakeFiles/cnd_adapters.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/jhrsdjl8bil6j7p7k5vp2m2lq78r8sz5-c3d-1.1.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/jhrsdjl8bil6j7p7k5vp2m2lq78r8sz5-c3d-1.1.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Attempted: c3d

Partial log (click to expand)

       ComparisonType(),
       ~~~~~~~~~~~~~~~~~
       destImage, srcImage);
       ~~~~~~~~~~~~~~~~~~~~
make[2]: *** [CMakeFiles/cnd_adapters.dir/build.make:639: CMakeFiles/cnd_adapters.dir/adapters/HessianEigenValues.cxx.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:695: CMakeFiles/cnd_adapters.dir/all] Error 2
make: *** [Makefile:163: all] Error 2
builder for '/nix/store/7kn7vjn3ngl0isv90s90wj2z4612qcdz-c3d-1.1.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/7kn7vjn3ngl0isv90s90wj2z4612qcdz-c3d-1.1.0.drv' failed

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

c3d seems also broken on master : https://hydra.nixos.org/build/72335751/nixlog/2

@bcdarwin
Copy link
Member Author

I have tried building c3d from updated sources but the same issue occurs. Perhaps it should be marked broken for now?

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

@bcdarwin seems reasonable.

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

What is the case regarding elastix?

@bcdarwin
Copy link
Member Author

bcdarwin commented Apr 10, 2018

Elastix updated, builds successfully now.

@bcdarwin
Copy link
Member Author

@Mic92 -- this pull request is going stale again already; is there anything remaining preventing it from being merged?

@Mic92 Mic92 merged commit d6ab165 into NixOS:master Apr 21, 2018
@bcdarwin
Copy link
Member Author

Thanks!!

@bcdarwin bcdarwin deleted the minc_ecosystem branch April 21, 2018 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants