Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cockroachdb: 1.1.5 -> 2.0.0 #38662

Merged
merged 2 commits into from Apr 17, 2018
Merged

cockroachdb: 1.1.5 -> 2.0.0 #38662

merged 2 commits into from Apr 17, 2018

Conversation

jbboehr
Copy link
Contributor

@jbboehr jbboehr commented Apr 9, 2018

Motivation for this change

Lots of shiny new features: https://www.cockroachlabs.com/docs/releases/v2.0.0.html#core-features

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

One of the dependencies failed to build without -ltinfo, so I've added ncurses6 to the buildInputs.

@bdarnell
Copy link
Contributor

This still needs a little work: the Go version pin in all-packages.nix needs to be removed, and on darwin it requires libedit (this is an undocumented dependency because we didn't contemplate darwin build environments that don't include things that are present in the default xcode install)

I'm working on an alternative PR that also refactors it to use stdenv.mkDerivation, since building cockroachdb from a source tarball is more like a standard tarball build that happens to depend on go than a typical go package.

@bdarnell bdarnell mentioned this pull request Apr 15, 2018
Closed
8 tasks
@jbboehr
Copy link
Contributor Author

jbboehr commented Apr 15, 2018 •
edited

To be fair, I changed the minimum possible to update the package - I would consider any changes to how the package is built not the scope of my PR.

@jbboehr
Copy link
Contributor Author

jbboehr commented Apr 15, 2018

@bdarnell I noticed in your PR you did not change all-packages.nix - I assume you were working off 18.03 and realized it wasn't necessary after rebasing onto master (like me)?

@bdarnell
Copy link
Contributor

Yeah, I was looking at an old version of all-packages.nix that still had the Go pin. Sorry for the confusion.

@jbboehr
Copy link
Contributor Author

jbboehr commented Apr 15, 2018

@bdarnell I see you are a major contributor to CRDB - I would be interested if you had any comments on my other PR #38665 at least from the CRDB side of things.

@Mic92
Copy link
Member

Mic92 commented Apr 17, 2018

@GrahamcOfBorg build cockroachdb

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: cockroachdb

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-darwin (full log)

Attempted: cockroachdb

Partial log (click to expand)

find: '/nix/store/cwal4gq9iyj3dvndlclhz3v8dyli1lgy-cockroach-2.0.0': No such file or directory
find: '/nix/store/cwal4gq9iyj3dvndlclhz3v8dyli1lgy-cockroach-2.0.0': No such file or directory
find: '/nix/store/cwal4gq9iyj3dvndlclhz3v8dyli1lgy-cockroach-2.0.0': No such file or directory
find: '/nix/store/cwal4gq9iyj3dvndlclhz3v8dyli1lgy-cockroach-2.0.0': No such file or directory
find: '/nix/store/cwal4gq9iyj3dvndlclhz3v8dyli1lgy-cockroach-2.0.0': No such file or directory
find: '/nix/store/cwal4gq9iyj3dvndlclhz3v8dyli1lgy-cockroach-2.0.0': No such file or directory
find: '/nix/store/cwal4gq9iyj3dvndlclhz3v8dyli1lgy-cockroach-2.0.0': No such file or directory
find: '/nix/store/cwal4gq9iyj3dvndlclhz3v8dyli1lgy-cockroach-2.0.0': No such file or directory
find: '/nix/store/cwal4gq9iyj3dvndlclhz3v8dyli1lgy-cockroach-2.0.0': No such file or directory
/nix/store/ybmvsksfqhgrcin4z4mbfjbayjm46yqk-cockroach-2.0.0-bin

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: cockroachdb

Partial log (click to expand)

post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rw52f8x4h0h39b7ndnhcbfxzwmxlv8cv-cockroach-2.0.0-bin
shrinking /nix/store/rw52f8x4h0h39b7ndnhcbfxzwmxlv8cv-cockroach-2.0.0-bin/bin/cockroach
gzipping man pages under /nix/store/rw52f8x4h0h39b7ndnhcbfxzwmxlv8cv-cockroach-2.0.0-bin/share/man/
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/rw52f8x4h0h39b7ndnhcbfxzwmxlv8cv-cockroach-2.0.0-bin/bin
patching script interpreter paths in /nix/store/rw52f8x4h0h39b7ndnhcbfxzwmxlv8cv-cockroach-2.0.0-bin
checking for references to /build in /nix/store/rw52f8x4h0h39b7ndnhcbfxzwmxlv8cv-cockroach-2.0.0-bin...
strip is /nix/store/j75dgadrff2d1fyc4fczmcgqkid2imdx-binutils-2.30/bin/strip
/nix/store/rw52f8x4h0h39b7ndnhcbfxzwmxlv8cv-cockroach-2.0.0-bin

@Mic92 Mic92 merged commit 329ca7d into NixOS:master Apr 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbboehr @bdarnell @Mic92 @GrahamcOfBorg