Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dit: init at 0.4 #38670

Merged
merged 1 commit into from Apr 11, 2018
Merged

dit: init at 0.4 #38670

merged 1 commit into from Apr 11, 2018

Conversation

davidak
Copy link
Member

@davidak davidak commented Apr 10, 2018 •
edited

Motivation for this change

We don't have enough editors packaged. Just kidding.

I want to try this editor out which might be a good alternative to nano.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@davidak
Copy link
Member Author

davidak commented Apr 10, 2018

Is it ok to add a package with broken darwin support or should i remove darwin support completely and readd when problem is fixed upstream?

@davidak davidak mentioned this pull request Apr 10, 2018
Closed
@davidak davidak changed the title [WIP] dit: init at 0.4 dit: init at 0.4 Apr 10, 2018
@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

@GrahamcOfBorg build dit

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: dit

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: dit

Partial log (click to expand)

make[2]: Leaving directory '/build/dit-0.4'
make[1]: Leaving directory '/build/dit-0.4'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/2r7crkbxafvqljw41b0fkhk7xsp4zdj7-dit-0.4
shrinking /nix/store/2r7crkbxafvqljw41b0fkhk7xsp4zdj7-dit-0.4/bin/dit
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/2r7crkbxafvqljw41b0fkhk7xsp4zdj7-dit-0.4/bin
patching script interpreter paths in /nix/store/2r7crkbxafvqljw41b0fkhk7xsp4zdj7-dit-0.4
checking for references to /build in /nix/store/2r7crkbxafvqljw41b0fkhk7xsp4zdj7-dit-0.4...
/nix/store/2r7crkbxafvqljw41b0fkhk7xsp4zdj7-dit-0.4

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: dit

Partial log (click to expand)

make[2]: Leaving directory '/build/dit-0.4'
make[1]: Leaving directory '/build/dit-0.4'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bc4cak37vadxbws954r654lqllvb9cd5-dit-0.4
shrinking /nix/store/bc4cak37vadxbws954r654lqllvb9cd5-dit-0.4/bin/dit
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bc4cak37vadxbws954r654lqllvb9cd5-dit-0.4/bin
patching script interpreter paths in /nix/store/bc4cak37vadxbws954r654lqllvb9cd5-dit-0.4
checking for references to /build in /nix/store/bc4cak37vadxbws954r654lqllvb9cd5-dit-0.4...
/nix/store/bc4cak37vadxbws954r654lqllvb9cd5-dit-0.4

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018 •
edited

Which dependency for dit is actually missing on macOS?

@davidak
Copy link
Member Author

davidak commented Apr 10, 2018

@Mic92 librt

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018 •
edited

But where is it used? Because it is not in buildInputs.

@davidak
Copy link
Member Author

davidak commented Apr 10, 2018

I'm not sure, but i think it's part of linux.

http://refspecs.linuxbase.org/LSB_3.0.0/LSB-PDA/LSB-PDA/librt.html#STD-223-67-TBL-LIBRT-CLO-INTS

./configure fails on darwin, as you see in the linked issue.

@davidak
Copy link
Member Author

davidak commented Apr 11, 2018

Since i don't got a response in the upstream issue yet and they don't do very frequently releases i assume it will take some time until darwin is supported. So i removed darwin support for now (still have it in a dit-darwin branch in my nixpkgs fork).

So good to merge now from my side.

@lukateras lukateras merged commit c625dbe into NixOS:master Apr 11, 2018
@davidak davidak deleted the dit branch April 11, 2018 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukateras lukateras lukateras approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@davidak @Mic92 @GrahamcOfBorg @lukateras