Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

texstudio: 2.12.6 -> 2.12.8 #38663

Merged
merged 1 commit into from Apr 10, 2018
Merged

texstudio: 2.12.6 -> 2.12.8 #38663

merged 1 commit into from Apr 10, 2018

Conversation

ajs124
Copy link
Member

@ajs124 ajs124 commented Apr 10, 2018

move to github

Motivation for this change

New release, which is not available on sourceforge anymore.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Apr 10, 2018

@GrahamcOfBorg build texstudio

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: texstudio

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: texstudio

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

dotlambda
dotlambda requested changes Apr 10, 2018
View reviewed changes
pkgs/applications/editors/texstudio/default.nix Outdated
@@ -2,13 +2,13 @@

stdenv.mkDerivation rec {
pname = "texstudio";
version = "2.12.6";
version = "2.12.8";
name = "${pname}-${version}";
altname="Texstudio";

src = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please use fetchFromGitHub.

pkgs/applications/editors/texstudio/default.nix Outdated
@@ -2,13 +2,13 @@

stdenv.mkDerivation rec {
pname = "texstudio";
version = "2.12.6";
version = "2.12.8";
name = "${pname}-${version}";
altname="Texstudio";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this line is needed.

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: texstudio

Partial log (click to expand)

shrinking RPATHs of ELF executables and libraries in /nix/store/4dzy9rvbn46g5syaaql8zj44xlkwmjzb-texstudio-2.12.8
shrinking /nix/store/4dzy9rvbn46g5syaaql8zj44xlkwmjzb-texstudio-2.12.8/bin/texstudio
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4dzy9rvbn46g5syaaql8zj44xlkwmjzb-texstudio-2.12.8/bin
patching script interpreter paths in /nix/store/4dzy9rvbn46g5syaaql8zj44xlkwmjzb-texstudio-2.12.8
checking for references to /build in /nix/store/4dzy9rvbn46g5syaaql8zj44xlkwmjzb-texstudio-2.12.8...
postPatchMkspecs
postPatchMkspecs
postPatchMkspecs
/nix/store/4dzy9rvbn46g5syaaql8zj44xlkwmjzb-texstudio-2.12.8

@ajs124
Copy link
Member Author

ajs124 commented Apr 10, 2018

Like this?

@dotlambda dotlambda merged commit 7d2e232 into NixOS:master Apr 10, 2018
@ajs124 ajs124 deleted the texstudio_2_12_8 branch July 31, 2018 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ajs124 @Mic92 @GrahamcOfBorg @dotlambda