pidgin-discord: init at 0.9.2018.04.10.git.9a97886 #38679
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtojnar
requested changes
Apr 10, 2018
| ]; | ||
|
|
||
| installPhase = '' | ||
| install -Dm755 -t $out/lib/pidgin/ libdiscord.so |
There was a problem hiding this comment.
Does not the default install phase work? You can overwrite the pkgconfig variables using PKG_CONFIG_${package}_${variable} (e.g. PKG_CONFIG_PURPLE_PLUGINDIR = "lib/pidgin";)
| buildInputs = [ pkgconfig pidgin json_glib ]; | ||
|
|
||
| makeFlags = [ | ||
| "PLUGIN_DIR_PURPLE=/lib/pidgin/" |
| sha256 = "0dc344zh1v4yh9c8javcw5ylzwc1wpx0ih8bww8p8cjmhr8kcl32"; | ||
| }; | ||
|
|
||
| buildInputs = [ pkgconfig pidgin json_glib ]; |
There was a problem hiding this comment.
pkgconfig should go to nativeBuildInputs.
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "pidgin-discord-${version}"; | ||
| version = "0.9.2018.04.10.git.9a97886"; |
There was a problem hiding this comment.
version is supposed to be unstable-yyyy-mm-dd: https://nixos.org/nixpkgs/manual/#sec-package-naming
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adds new pidgin plugin that brings Discord support. In addition, add myself to the maintainers list.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)