New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xmrig-proxy: init at 2.5.2 #38669
xmrig-proxy: init at 2.5.2 #38669
Conversation
buildInputs = [ libuv libmicrohttpd libuuid ]; | ||
|
||
postPatch = '' | ||
substituteInPlace src/donate.h --replace "kDonateLevel = 2;" "kDonateLevel = ${toString donateLevel};" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this value mean? what means a level of 2 and what means zero?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be added as a comment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's the default percentage of hashpower to donate to the xmrig developer. Comment added.
It is commented fairly well upstream: https://github.com/xmrig/xmrig-proxy/blob/694446bb72b1b31fba6d46f6d8ee13f2f08407c0/src/donate.h
I based this on 5d86c50, assuming the same reasoning applies here as well.
I have fewer than 256 workers, so this doesn't actually affect me, but I dislike pickpocket-style "donations" on principle.
$ xmrig-proxy
unable to open /nix/store/w8rv7q5kcgv3cxrrbdm1xw27rs1zlycb-xmrig-proxy-2.5.2/bin/config.json: no such file or directory
No pool URL supplied. Exiting. Should be maybe changed to just |
This one could be replaced by "config.json". |
Are you sure you want to use this software? |
@Mic92 I only tested with a configuration. It does seem weird for it to look for a config in bindir by default. Perhaps that makes more sense on Windows? It does read from the network... 😟 |
The rest of program does not look as scary as this part. |
Motivation for this change
xmrig-proxy can proxy a bunch of crypnonight miners, reducing connection count and/or making them easier to manage.
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)