Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.zfs{Stable,Unstable}: Enospec fix #38672

Merged
merged 1 commit into from Apr 10, 2018
Merged

linuxPackages.zfs{Stable,Unstable}: Enospec fix #38672

merged 1 commit into from Apr 10, 2018

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Apr 10, 2018 •
edited

Motivation for this change

Replaces #38668

Fixes major regression: openzfs/zfs#7401

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member Author

Mic92 commented Apr 10, 2018

Running tests now...

@adisbladis
Copy link
Member

@GrahamcOfBorg test zfs

@GrahamcOfBorg
Copy link

No attempt on x86_64-linux (full log)

The following builds were skipped because they don't evaluate on x86_64-linux: tests.zfs

Partial log (click to expand)

Cannot nix-instantiate `tests.zfs' because:
error: attribute 'zfs' in selection path 'tests.zfs' not found

@GrahamcOfBorg
Copy link

No attempt on aarch64-linux (full log)

The following builds were skipped because they don't evaluate on aarch64-linux: tests.zfs

Partial log (click to expand)

Cannot nix-instantiate `tests.zfs' because:
�[31;1merror:�[0m attribute 'zfs' in selection path 'tests.zfs' not found

@Mic92 Mic92 mentioned this pull request Apr 10, 2018
Closed
@Mic92
Copy link
Member Author

Mic92 commented Apr 10, 2018 •
edited

Tests finished here, waiting now for nix-review to finish

@gebner gebner added the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 10, 2018
@Mic92
Copy link
Member Author

Mic92 commented Apr 10, 2018

It breaks on the bcachefs kernel, but this was probably already the case before.

@Mic92 Mic92 merged commit c4f555a into NixOS:master Apr 10, 2018
@Mic92 Mic92 deleted the zfs-enospc-fix branch April 10, 2018 07:07
@Mic92
Copy link
Member Author

Mic92 commented Apr 10, 2018

18.03:

[detached HEAD 023feb5] linuxPackages.{zfs,spl}{Stable,Unstable}: 0.7.7 -> 0.7.8; 2018-04-04 -> 2018-04-10
Date: Tue Apr 10 06:37:35 2018 +0100
4 files changed, 188 insertions(+), 23 deletions(-)
create mode 100644 pkgs/os-specific/linux/spl/install_prefix-0.7.8.patch

@gebner gebner mentioned this pull request Apr 10, 2018
Closed
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Mic92 @adisbladis @GrahamcOfBorg @samueldr @gebner