libhttpseverywhere: fix build (tests) #37546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Success on aarch64-linux (full log) Attempted: libhttpseverywhere Partial log (click to expand)
|
|
Success on x86_64-linux (full log) Attempted: libhttpseverywhere Partial log (click to expand)
|
dezgeg
reviewed
Mar 21, 2018
| @@ -19,7 +19,7 @@ in stdenv.mkDerivation rec { | |||
|
|
|||
| doCheck = true; | |||
|
|
|||
| checkPhase = "./httpseverywhere_test"; | |||
| checkPhase = "cd test && ./httpseverywhere_test && cd .."; | |||
There was a problem hiding this comment.
I think more typical is (cd test && ./httpseverywhere_test) so you don't need to cd back.
There was a problem hiding this comment.
thanks, that look better.
run tests in correct directory
xeji
force-pushed
the
p/libhttpseverywhere
branch
from
6eccd1d
to
7f0972e
Compare
|
Success on x86_64-linux (full log) Attempted: libhttpseverywhere Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: libhttpseverywhere Partial log (click to expand)
|
|
Cherry-picked to 18.03 in 5995e9c, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Tests failed after update to v0.8 (wrong directory).
/cc ZHF #36453
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)