Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: pipenv: 10.1.2 -> 11.8.3 #37547

Closed
wants to merge 1 commit into from
Closed

python: pipenv: 10.1.2 -> 11.8.3 #37547

wants to merge 1 commit into from

Conversation

suvash
Copy link
Contributor

@suvash suvash commented Mar 21, 2018 •
edited

Updates pipenv to the latest version available

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@suvash
python: pipenv: 10.1.2 -> 11.8.3
79fe28d 
Updates pipenv to the latest version available
@suvash
Copy link
Contributor Author

suvash commented Mar 21, 2018

DO NOT MERGE ! Build goes fine, but pipenv has some issues. will try to fix and push changes.

@suvash
Copy link
Contributor Author

suvash commented Mar 21, 2018 •
edited

@berdario @zimbatm @FRidh Can you help figure out why pipenv --three etc. doesn't work with this update ? I believe it has something to do with pew, but I'm not completely sure.

I installed it manually via nix-env -f $NIXPKGS_DIR -iA pipenv, and that went fine.

Error logs below, on usage.

> pipenv --three
Creating a virtualenv for this project…
Using /nix/store/b8gd0cbvkm59x8flbc53bvsvmskyig5a-python3-3.6.4/bin/python3 (3.6.4) to create virtualenv…
⠋/nix/store/b8gd0cbvkm59x8flbc53bvsvmskyig5a-python3-3.6.4/bin/python3.6m: Error while finding module specification for 'pipenv.pew' (ModuleNotFoundError: No module named 'pipenv')

Virtualenv location: 
Creating a Pipfile for this project…
Traceback (most recent call last):
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/bin/.pipenv-wrapped", line 12, in <module>
    sys.exit(cli())
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 722, in __call__
    return self.main(*args, **kwargs)
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 697, in main
    rv = self.invoke(ctx)
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 1043, in invoke
    return Command.invoke(self, ctx)
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 895, in invoke
    return ctx.invoke(self.callback, **ctx.params)
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/vendor/click/core.py", line 535, in invoke
    return callback(*args, **kwargs)
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/vendor/click/decorators.py", line 17, in new_func
    return f(get_current_context(), *args, **kwargs)
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/cli.py", line 235, in cli
    three=three, python=python, warn=True, site_packages=site_packages
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/core.py", line 635, in ensure_project
    ensure_pipfile(validate=validate, skip_requirements=skip_requirements)
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/core.py", line 289, in ensure_pipfile
    project.create_pipfile(python=python)
  File "/nix/store/b3r698650vk88xrgsqj2rzm0k4a8swvz-pipenv-11.8.3/lib/python3.6/site-packages/pipenv/project.py", line 481, in create_pipfile
    'python_version': python_version(required_python)[: len('2.7')]
TypeError: 'NoneType' object is not subscriptable

@suvash suvash closed this Mar 26, 2018
@suvash suvash deleted the update-pipenv branch March 26, 2018 12:30
@svend svend mentioned this pull request Apr 3, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@suvash @GrahamcOfBorg