pythonPackages.face_recognition: init at 1.2.1 #37566

Ma27 · 2018-03-21T13:48:37Z

Motivation for this change

Adds the python package face_recognition and its dependency
face_recognition_models.

This package is a wrapper for dlib which is able to detect faces in a
given image. I checked the package with the following expression:

with import ./. { };

stdenv.mkDerivation {
  name = "facetest";
  src = null;
  buildInputs = with pythonPackages; [ face_recognition ];
}

The package works perfectly fine in a nix-shell:

$ nix-shell
[nix-shell:~]$ python
Python 2.7.14 (default, Sep 16 2017, 17:49:51)
[GCC 7.3.0] on linux2
Type "help", "copyright", "credits" or "license" for more information.
>>> import face_recognition
>>> img = face_recognition.load_image_file("/home/ma27/me.jpg")
>>> print(face_recognition.face_locations(img))

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

dotlambda · 2018-03-21T15:43:09Z

pkgs/development/python-modules/face_recognition/default.nix

+
+  propagatedBuildInputs = [ pillow click dlib numpy face_recognition_models scipy ];
+
+  doCheck = false;


my bad, they're not available with pypi, moving to fetchFromGitHub + active tests, just did some fast bootstrapping in an isolated environment, but you're right, active tests are way better %)

dotlambda · 2018-03-21T15:43:31Z

pkgs/development/python-modules/face_recognition_models/default.nix

+    sha256 = "1kwnv3qpy5bhspk780bkyg8jd9n5f6p91ja6sjlwk1wcm00d56xp";
+  };
+
+  # no module named `tests`


I think there are simply no tests: https://github.com/ageitgey/face_recognition_models

dotlambda · 2018-03-21T15:44:14Z

pkgs/development/python-modules/face_recognition/default.nix

+
+  meta = with stdenv.lib; {
+    license = licenses.mit;
+    homepage = https://pypi.python.org/pypi/face_recognition;


https://github.com/ageitgey/face_recognition

dotlambda · 2018-03-21T15:44:45Z

pkgs/development/python-modules/face_recognition/default.nix

+    license = licenses.mit;
+    homepage = https://pypi.python.org/pypi/face_recognition;
+    maintainers = with maintainers; [ ma27 ];
+  };


description is missing

dotlambda · 2018-03-21T15:45:04Z

pkgs/development/python-modules/face_recognition_models/default.nix

+  doCheck = false;
+
+  meta = with stdenv.lib; {
+    homepage = https://pypi.python.org/pypi/face_recognition_models;


https://github.com/ageitgey/face_recognition_models

dotlambda · 2018-03-21T15:45:21Z

pkgs/development/python-modules/face_recognition_models/default.nix

+    homepage = https://pypi.python.org/pypi/face_recognition_models;
+    license = licenses.cc0;
+    maintainers = with maintainers; [ ma27 ];
+  };


description missing

Ma27 · 2018-03-21T19:38:02Z

@dotlambda thanks a lot for the feedback, added tests for face_recognition, tested everything in a sandbox, should be fine now %)

dotlambda · 2018-03-21T20:42:54Z

@GrahamcOfBorg build python2.pkgs.face_recognition python3.pkgs.face_recognition

dotlambda · 2018-03-21T20:43:34Z

pkgs/development/python-modules/face_recognition/default.nix

+  pname = "face_recognition";
+  version = "1.2.1";
+
+  src = fetchFromGitHub {


You could add a comment why you're fetching from GitHub, and maybe open an upstream issue about missing tags.

@Ma27 Did you open an issue?

GrahamcOfBorg · 2018-03-21T20:49:24Z

Failure on x86_64-linux (full log)

Attempted: python2.pkgs.face_recognition, python3.pkgs.face_recognition

Partial log (click to expand)

test_raw_face_landmarks (tests.test_face_recognition.Test_face_recognition) ... ok
test_raw_face_locations (tests.test_face_recognition.Test_face_recognition) ... ok
test_raw_face_locations_32bit_image (tests.test_face_recognition.Test_face_recognition) ... ok
test_raw_face_locations_batched (tests.test_face_recognition.Test_face_recognition) ... ok

----------------------------------------------------------------------
Ran 22 tests in 285.080s

OK
error: build of '/nix/store/9bq6i0afkjj520z8820ln4sjgllh2v66-python3.6-face_recognition-1.2.1.drv' failed

GrahamcOfBorg · 2018-03-21T20:56:17Z

Failure on aarch64-linux (full log)

Attempted: python2.pkgs.face_recognition, python3.pkgs.face_recognition

Partial log (click to expand)

test_raw_face_landmarks (tests.test_face_recognition.Test_face_recognition) ... ok
test_raw_face_locations (tests.test_face_recognition.Test_face_recognition) ... ok
test_raw_face_locations_32bit_image (tests.test_face_recognition.Test_face_recognition) ... ok
test_raw_face_locations_batched (tests.test_face_recognition.Test_face_recognition) ... ok

----------------------------------------------------------------------
Ran 22 tests in 665.386s

OK
�[31;1merror:�[0m build of '/nix/store/lcpv8vq6vypzlvyishgs2fkvx7igc637-python3.6-face_recognition-1.2.1.drv' failed

Adds the python package `face_recognition` and its dependency `face_recognition_models`. This package is a wrapper for `dlib` which is able to detect faces in a given image. I checked the package with the following expression: ``` with import ./. { }; stdenv.mkDerivation { name = "facetest"; src = null; buildInputs = with pythonPackages; [ face_recognition ]; } ``` The package works perfectly fine in a `nix-shell`: ``` $ nix-shell [nix-shell:~]$ python Python 2.7.14 (default, Sep 16 2017, 17:49:51) [GCC 7.3.0] on linux2 Type "help", "copyright", "credits" or "license" for more information. >>> import face_recognition >>> img = face_recognition.load_image_file("/home/ma27/me.jpg") >>> print(face_recognition.face_locations(img)) ```

Ma27 · 2018-03-21T22:23:48Z

@dotlambda on python3 it was needed to set LC_ALL properly, tests passing locally now %)

dotlambda · 2018-03-21T22:25:09Z

@GrahamcOfBorg build python2.pkgs.face_recognition python3.pkgs.face_recognition

GrahamcOfBorg · 2018-03-21T22:29:52Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.face_recognition, python3.pkgs.face_recognition

Partial log (click to expand)

.
.
.
.
                    [100%]


========================== 22 passed in 85.85 seconds ==========================
/nix/store/ln3qphxg050g4rwky4rhb6q0xdc7q8sx-python2.7-face_recognition-1.2.1
/nix/store/fazsa9w1bc8amlcx62825gx1wr175mxp-python3.6-face_recognition-1.2.1

GrahamcOfBorg · 2018-03-21T22:36:25Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.face_recognition, python3.pkgs.face_recognition

Partial log (click to expand)

collected 22 items

tests/test_face_recognition.py ......................                    [100%]

========================= 22 passed in 636.35 seconds ==========================
tests/test_face_recognition.py ......................                    [100%]

========================= 22 passed in 640.29 seconds ==========================
/nix/store/4qqn9xkas96rx18mizy8na3pr8v4s72k-python2.7-face_recognition-1.2.1
/nix/store/czfwr3yfnn6k7qjkmixp2kpmirqk1wnf-python3.6-face_recognition-1.2.1

dotlambda · 2018-03-22T08:49:21Z

I tested this shortly and encountered

UnicodeEncodeError: 'ascii' codec can't encode character u'\xe4' in position 21: ordinal not in range(128)

when using Python 2. There was no problem with Python 3. Did you test both versions?

Ma27 · 2018-03-22T23:03:47Z

when using Python 2. There was no problem with Python 3. Did you test both versions?

Yes I did (see the results of the REPL session I copied into the commit message). I actually use this library on a simple test project with Python 2.7 and the current derivation lives in my local Nix store (built with sandbox enabled).
Can you give me a precise guidance to reproduce this issue?

Did you open an issue?

ageitgey/face_recognition#417

Ma27 · 2018-04-02T17:27:21Z

just to document it here: upstream will create git tags for their releases from now on, so with the next bump we can get rid of using revs that point to PyPI releases (ageitgey/face_recognition#417 (comment))

The following fixes have been applied according to the changelog (https://github.com/ageitgey/face_recognition/releases) - Added the face_detection CLI command - Removed dependencies on scipy to make installation easier - Cleaned up KNN example and fixed a bug with drawing fonts to label detected faces in the demo Furthermore the maintainer switched to actual GIT tags for PyPI releases as discussed in ageitgey/face_recognition#417 and NixOS#37566

Ma27 requested a review from FRidh as a code owner March 21, 2018 13:48

GrahamcOfBorg added 6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 21, 2018

dotlambda requested changes Mar 21, 2018

View reviewed changes

Ma27 force-pushed the init-face-recognition branch from cc00fce to 9612646 Compare March 21, 2018 19:37

dotlambda reviewed Mar 21, 2018

View reviewed changes

Ma27 force-pushed the init-face-recognition branch from 9612646 to c268641 Compare March 21, 2018 22:23

dotlambda approved these changes Mar 21, 2018

View reviewed changes

Ma27 mentioned this pull request Mar 22, 2018

Create git tags for PyPI releases ageitgey/face_recognition#417

Closed

dotlambda merged commit 1aedde9 into NixOS:master Mar 23, 2018

Ma27 deleted the init-face-recognition branch March 26, 2018 15:52

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.face_recognition: init at 1.2.1 #37566

pythonPackages.face_recognition: init at 1.2.1 #37566

Ma27 commented Mar 21, 2018 •

edited

dotlambda Mar 21, 2018

Ma27 Mar 21, 2018

dotlambda Mar 21, 2018

dotlambda Mar 21, 2018

dotlambda Mar 21, 2018

dotlambda Mar 21, 2018

dotlambda Mar 21, 2018

Ma27 commented Mar 21, 2018

dotlambda commented Mar 21, 2018

dotlambda Mar 21, 2018

dotlambda Mar 22, 2018

GrahamcOfBorg commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

Ma27 commented Mar 21, 2018

dotlambda commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

dotlambda commented Mar 22, 2018

Ma27 commented Mar 22, 2018

Ma27 commented Apr 2, 2018


		propagatedBuildInputs = [ pillow click dlib numpy face_recognition_models scipy ];

		doCheck = false;

pythonPackages.face_recognition: init at 1.2.1 #37566

pythonPackages.face_recognition: init at 1.2.1 #37566

Conversation

Ma27 commented Mar 21, 2018 • edited

Motivation for this change

Things done

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Ma27 commented Mar 21, 2018

dotlambda commented Mar 21, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

GrahamcOfBorg commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

Ma27 commented Mar 21, 2018

dotlambda commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

GrahamcOfBorg commented Mar 21, 2018

dotlambda commented Mar 22, 2018

Ma27 commented Mar 22, 2018

Ma27 commented Apr 2, 2018

Ma27 commented Mar 21, 2018 •

edited