Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Haskell: fix static libs on darwin #37509

Merged
merged 1 commit into from
Mar 21, 2018
Merged

Haskell: fix static libs on darwin #37509

merged 1 commit into from
Mar 21, 2018
+5 −1

Conversation

pikajude
Copy link
Contributor

@pikajude pikajude commented Mar 21, 2018 •
edited
Loading

Motivation for this change

As far as I can tell, the Sierra links hack goes down a bad code path if we have enableSharedLibraries = false.

Haskell packages broke for me a number of revs ago and I bisected it to aa05451, but that commit appears to have just made the problem more obvious, since by default it would otherwise be avoided.

Note that this is only a mass rebuild because it changes the expressions for the GHC bootstrapping packages.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@pikajude pikajude requested a review from peti as a code owner March 21, 2018 00:31
@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Mar 21, 2018
@pikajude pikajude changed the title fix static libs on darwin Haskell: fix static libs on darwin Mar 21, 2018
@GrahamcOfBorg GrahamcOfBorg added 6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 21, 2018
@pikajude pikajude merged commit d6a0652 into NixOS:master Mar 21, 2018
@pikajude pikajude deleted the darwin-hs-dynamic branch March 21, 2018 21:36
@matthewbauer matthewbauer mentioned this pull request Mar 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7

@peti peti

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 6.topic: haskell 10.rebuild-darwin: 501+ 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pikajude @LnL7 @GrahamcOfBorg