Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-webkit/nw9.nix: remove #37568

Merged
merged 1 commit into from Mar 21, 2018
Merged

node-webkit/nw9.nix: remove #37568

merged 1 commit into from Mar 21, 2018

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Mar 21, 2018 •
edited

Motivation for this change

Obsolete since #37380 and severly outdated (#37361)

/cc @Profpatsch

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ma27
node-webkit/nw9.nix: remove
fe71ffd 
Obsolete since NixOS#37380 and severly outdated (NixOS#37361)

/cc @Profpatsch
@Ma27 Ma27 mentioned this pull request Mar 21, 2018
Merged
8 tasks
@globin globin merged commit 9f6d1ac into NixOS:master Mar 21, 2018
@Ma27 Ma27 deleted the remove-nw9.nix branch March 21, 2018 14:44
@Profpatsch
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @Profpatsch @globin @GrahamcOfBorg