Skip to content

pan: update 0.139 -> 0.144, fix crash on startup, dep and feature wrangling. #37561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 21, 2018
Merged

pan: update 0.139 -> 0.144, fix crash on startup, dep and feature wrangling. #37561

merged 4 commits into from
Mar 21, 2018
+24 −11

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 21, 2018 •
edited
Loading

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 21, 2018
@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: pan

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pan

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/4h09xl65fiwr5vjd3g88g445z5nfjsf0-pan-0.144
shrinking /nix/store/4h09xl65fiwr5vjd3g88g445z5nfjsf0-pan-0.144/bin/.pan-wrapped
gzipping man pages under /nix/store/4h09xl65fiwr5vjd3g88g445z5nfjsf0-pan-0.144/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/4h09xl65fiwr5vjd3g88g445z5nfjsf0-pan-0.144/bin
patching script interpreter paths in /nix/store/4h09xl65fiwr5vjd3g88g445z5nfjsf0-pan-0.144
checking for references to /build in /nix/store/4h09xl65fiwr5vjd3g88g445z5nfjsf0-pan-0.144...
/nix/store/4h09xl65fiwr5vjd3g88g445z5nfjsf0-pan-0.144

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pan

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/bsi14g1i1kand78c09975rscv161g51s-pan-0.144
shrinking /nix/store/bsi14g1i1kand78c09975rscv161g51s-pan-0.144/bin/.pan-wrapped
gzipping man pages under /nix/store/bsi14g1i1kand78c09975rscv161g51s-pan-0.144/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/bsi14g1i1kand78c09975rscv161g51s-pan-0.144/bin
patching script interpreter paths in /nix/store/bsi14g1i1kand78c09975rscv161g51s-pan-0.144
checking for references to /build in /nix/store/bsi14g1i1kand78c09975rscv161g51s-pan-0.144...
/nix/store/bsi14g1i1kand78c09975rscv161g51s-pan-0.144

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin

The following builds were skipped because they don't evaluate on x86_64-darwin: pan

No partial log is available.

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: pan

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/3a78qk2fxc2m1kr31mb35c69wg3r2vvq-pan-0.144
shrinking /nix/store/3a78qk2fxc2m1kr31mb35c69wg3r2vvq-pan-0.144/bin/.pan-wrapped
gzipping man pages under /nix/store/3a78qk2fxc2m1kr31mb35c69wg3r2vvq-pan-0.144/share/man/
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/3a78qk2fxc2m1kr31mb35c69wg3r2vvq-pan-0.144/bin
patching script interpreter paths in /nix/store/3a78qk2fxc2m1kr31mb35c69wg3r2vvq-pan-0.144
checking for references to /build in /nix/store/3a78qk2fxc2m1kr31mb35c69wg3r2vvq-pan-0.144...
/nix/store/3a78qk2fxc2m1kr31mb35c69wg3r2vvq-pan-0.144

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: pan

Partial log (click to expand)

glibPreFixupPhase
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/va87r9m1z8wx54hnh0b0gkcwn4p0pr9j-pan-0.144
shrinking /nix/store/va87r9m1z8wx54hnh0b0gkcwn4p0pr9j-pan-0.144/bin/.pan-wrapped
gzipping man pages under /nix/store/va87r9m1z8wx54hnh0b0gkcwn4p0pr9j-pan-0.144/share/man/
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/va87r9m1z8wx54hnh0b0gkcwn4p0pr9j-pan-0.144/bin
patching script interpreter paths in /nix/store/va87r9m1z8wx54hnh0b0gkcwn4p0pr9j-pan-0.144
checking for references to /build in /nix/store/va87r9m1z8wx54hnh0b0gkcwn4p0pr9j-pan-0.144...
/nix/store/va87r9m1z8wx54hnh0b0gkcwn4p0pr9j-pan-0.144

@dtzWill dtzWill changed the title pan: 0.139 -> 0.144, fix crash on startup [WIP] pan: 0.139 -> 0.144, fix crash on startup Mar 21, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2018

One sec, investigating some dep fixups.

@dtzWill dtzWill force-pushed the fix/pan-and-update branch from e9c25e5 to 7d873b8 Compare March 21, 2018 14:48
@dtzWill
pan: enable spell-checking features by default
63ba349 
Seems to work, not sure why disabled.

Steps are something like:
* install dictionaries into profile
* attempt to compose a message
  * (navigate dialogs about server and posting profile)
* enable spell-checking from edit->checkbox
  (note this toggle is avail even when pan can't spellcheck)
@dtzWill dtzWill changed the title [WIP] pan: 0.139 -> 0.144, fix crash on startup pan: update 0.139 -> 0.144, fix crash on startup, dep and feature wrangling. Mar 21, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2018

Look okay @edolstra ? (maintainer)

@edolstra
Copy link
Member

Yes, looks good to me. BTW I haven't used Pan in years, so if somebody wants to take over as maintainer, feel free to do so.

@dtzWill
Copy link
Member Author

dtzWill commented Mar 21, 2018

Thanks! Just wanted to double-check in case this would break your favorite app! ;) :D.

@dtzWill dtzWill merged commit c932a74 into NixOS:master Mar 21, 2018
@dtzWill dtzWill deleted the fix/pan-and-update branch March 21, 2018 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @GrahamcOfBorg @edolstra