Fix itemprop errors from w3c validator in jinja themes #2994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://validator.w3c.org flags itemprop attributes as an error on any element that specifies them unless the itemtype attribute in a parent element references a valid schema. The validation error is: "Error: the itemprop attribute was specified but the element is not a property of any item" This change fixes the validation error.
|
The -jinja themes are autogenerated using scripts/jinjify from their mako siblings. Could you make the same change in base instead of base-jinja and then run jinjify? If not, I can do it. |
|
I can see the change in both versions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://validator.w3c.org flags itemprop attributes as an error
on any element that specifies them unless the itemtype attribute
in a parent element references a valid schema. The validation
error is:
"Error: the itemprop attribute was specified but the element is
not a property of any item"
This change fixes the validation error.
Pull Request Checklist
Description