Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oraclejdk: add version 10 #37523

Merged
merged 1 commit into from Mar 23, 2018
Merged

oraclejdk: add version 10 #37523

merged 1 commit into from Mar 23, 2018

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Mar 21, 2018

Motivation for this change
  • Local-variable type inference
  • Additional Unicode language-tag extensions
  • Time-based release versioning
  • Better Docker support
  • Parallel full GC for G1
  • Removal of deprecated methods and features
  • etc.

http://www.oracle.com/technetwork/java/javase/10-relnote-issues-4108729.html

Oracle JDK/JRE 9 is no longer updated. Should we remove nixexprs for those packages?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

thoughtpolice
thoughtpolice approved these changes Mar 23, 2018
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it would be nice to axe JDK 9 -- the new 6 month release schedule means we should kill it before too long, probably, and maybe even backport to 18.03... That can happen in another PR, though.

In the mean time I've tested this on my NixOS machine and it works nicely; and IMO I feel the warning about jdk9 is OK because openjdk is unfree anyway (so too many people won't be hurt). Merging.

@thoughtpolice thoughtpolice merged commit d2d859d into NixOS:master Mar 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thoughtpolice thoughtpolice thoughtpolice approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @thoughtpolice @GrahamcOfBorg