Navigation Menu

Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: SpongePowered/Sponge
base: 89cf3d7a0c70^
Choose a base ref
...
head repository: SpongePowered/Sponge
compare: 25930b23df55
Choose a head ref
  • 3 commits
  • 4 files changed
  • 1 contributor

Commits on Mar 20, 2018

  1. Don't reschedule block ticks for areas not loaded. 

    Blocks that sit on edge chunks (chunks who have no neighbors) may
trigger a scheduled update in that area not loaded. We patch the
isAreaLoaded check to not do chunk lookups (and instead neighbor
pointers) but now we'll have scheduled updates continuning forever (or
at the least until the neighbors of that chunk load). This commit
removes this concept.

Possible drawbacks may be automated farms on edge chunks but I find it
an acceptable compromise that edge chunks shouldn't be able to schedule
outside those bounds. If this becomes a problem, we can issue a
configurable option.

Signed-off-by: Chris Sanders <zidane@spongepowered.org>
    @Zidane
    Zidane committed Mar 20, 2018
    Copy the full SHA
    89cf3d7 View commit details
    Browse the repository at this point in the history

  2. Have liquids not schedule updates when added to the world during world 

    gen.

Signed-off-by: Chris Sanders <zidane@spongepowered.org>
    @Zidane
    Zidane committed Mar 20, 2018
    Copy the full SHA
    a0143d7 View commit details
    Browse the repository at this point in the history

  3. Don't allow neighbor block updates to trigger chunk loads ever. 

    Signed-off-by: Chris Sanders <zidane@spongepowered.org>
    @Zidane
    Zidane committed Mar 20, 2018
    Copy the full SHA
    25930b2 View commit details
    Browse the repository at this point in the history