python-docx: init at 0.8.6 #38722

AJChapman · 2018-04-11T05:08:40Z

Motivation for this change

This library is a required dependency for something I need to build.

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

FRidh · 2018-04-11T05:33:05Z

pkgs/development/python-modules/python-docx/default.nix

+buildPythonPackage rec {
+  pname = "python-docx";
+  version = "0.8.6";
+  name = "${pname}-${version}";


The name attribute is added by buildPython* and should therefore be removed.

FRidh · 2018-04-11T05:38:24Z

@GrahamcOfBorg build python3.pkgs.python-docx

GrahamcOfBorg · 2018-04-11T05:38:51Z

Failure on x86_64-linux (full log)

Attempted: python3.pkgs.python-docx

Partial log (click to expand)

Reading https://pypi.python.org/simple/pytest/
Download error on https://pypi.python.org/simple/pytest/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'pytest' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for pytest
error: Could not find suitable distribution for Requirement.parse('pytest')
builder for '/nix/store/dimjbvxwszqizm73l14wprfhcg6akls6-python3.6-python-docx-0.8.6.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/dimjbvxwszqizm73l14wprfhcg6akls6-python3.6-python-docx-0.8.6.drv' failed

GrahamcOfBorg · 2018-04-11T05:39:16Z

Failure on aarch64-linux (full log)

Attempted: python3.pkgs.python-docx

Partial log (click to expand)

Reading https://pypi.python.org/simple/pytest/
Download error on https://pypi.python.org/simple/pytest/: [Errno -2] Name or service not known -- Some packages may not be found!
Couldn't find index page for 'pytest' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading https://pypi.python.org/simple/
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
No local packages or working download links found for pytest
error: Could not find suitable distribution for Requirement.parse('pytest')
builder for '/nix/store/dwp9vg65yjwsxw4qsr2kdgg8hqac5rq3-python3.6-python-docx-0.8.6.drv' failed with exit code 1
�[31;1merror:�[0m build of '/nix/store/dwp9vg65yjwsxw4qsr2kdgg8hqac5rq3-python3.6-python-docx-0.8.6.drv' failed

GrahamcOfBorg · 2018-04-11T05:39:32Z

Success on x86_64-darwin (full log)

Attempted: python3.pkgs.python-docx

Partial log (click to expand)

reading manifest file 'python_docx.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'python_docx.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/4vbr4mknj177smwa1zp4frs54syj62fv-python3.6-python-docx-0.8.6

FRidh · 2018-04-11T05:42:25Z

Test dependencies are missing. I suggest testing with the sandbox turned on.

AJChapman · 2018-04-11T11:07:35Z

I may have fixed these, not sure if my nix.useSandbox = true is working...

AJChapman · 2018-04-11T11:07:41Z

@GrahamcOfBorg build python3.pkgs.python-docx

AJChapman · 2018-04-12T06:13:46Z

Ok @FRidh, I think I have it working now.

dotlambda

Please squash the commits and use

pythonPackages.python-docx: init at 0.8.6

as the commit message.

dotlambda · 2018-04-13T08:42:46Z

pkgs/development/python-modules/python-docx/default.nix

+    sha256 = "117i84s6fcdsrfckbvznnqgqwhnf1x0523ps16cki8sg9byydv2m";
+  };
+
+  buildInputs = [ behave lxml pytest pyparsing mock ];


lxml belongs into propagatedBuildInputs, the rest into checkInputs

dotlambda · 2018-04-13T08:42:56Z

pkgs/development/python-modules/python-docx/default.nix

+
+  meta = {
+    description = "Create and update Microsoft Word .docx files";
+    homepage = "https://python-docx.readthedocs.io/en/latest/";


dotlambda · 2018-04-13T08:44:30Z

@GrahamcOfBorg build python3.pkgs.python-docx

GrahamcOfBorg · 2018-04-13T08:45:07Z

Success on aarch64-linux (full log)

Attempted: python3.pkgs.python-docx

Partial log (click to expand)

reading manifest file 'python_docx.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'python_docx.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.002s

OK
/nix/store/yb8p86g2j1qhh5r80a1fmkhpfh2vgki5-python3.6-python-docx-0.8.6

GrahamcOfBorg · 2018-04-13T08:45:07Z

Success on x86_64-linux (full log)

Attempted: python3.pkgs.python-docx

Partial log (click to expand)

reading manifest file 'python_docx.egg-info/SOURCES.txt'
reading manifest template 'MANIFEST.in'
writing manifest file 'python_docx.egg-info/SOURCES.txt'
running build_ext

----------------------------------------------------------------------
Ran 0 tests in 0.000s

OK
/nix/store/hv5qp66hvnh0k9nwzxny6siiwanznc81-python3.6-python-docx-0.8.6

dotlambda · 2018-04-13T08:47:05Z

Ran 0 tests in 0.000s

Please specify an appropriate checkPhase, e.g.

checkPhase = ''
  py.test
'';

AJChapman · 2018-04-15T00:45:43Z

checkPhase added, dependencies updated, commits squashed, and commit message updated. Thanks for the thorough review!

dotlambda · 2018-04-15T05:59:36Z

@GrahamcOfBorg build python2.pkgs.python-docx python3.pkgs.python-docx

GrahamcOfBorg · 2018-04-15T06:00:15Z

Success on x86_64-linux (full log)

Attempted: python2.pkgs.python-docx, python3.pkgs.python-docx

Partial log (click to expand)


=============================== warnings summary ===============================
tests/styles/test_styles.py::DescribeStyles::()::it_can_get_a_style_by_id[getitem_id_fixture0]
  /build/python-docx-0.8.6/docx/styles/styles.py:54: UserWarning: style lookup by style_id is deprecated. Use style name as key instead.
    warn(msg, UserWarning)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
=================== 1354 passed, 1 warnings in 5.45 seconds ====================
/nix/store/k2prjffaa6kggi2sskgncy1l059pwi9x-python2.7-python-docx-0.8.6
/nix/store/dnqkqpmz84zws4ysb1fw7ja86lspbdj9-python3.6-python-docx-0.8.6

GrahamcOfBorg · 2018-04-15T06:01:00Z

Success on aarch64-linux (full log)

Attempted: python2.pkgs.python-docx, python3.pkgs.python-docx

Partial log (click to expand)


=============================== warnings summary ===============================
tests/styles/test_styles.py::DescribeStyles::()::it_can_get_a_style_by_id[getitem_id_fixture0]
  /build/python-docx-0.8.6/docx/styles/styles.py:54: UserWarning: style lookup by style_id is deprecated. Use style name as key instead.
    warn(msg, UserWarning)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
=================== 1354 passed, 1 warnings in 38.85 seconds ===================
/nix/store/aiphsx26j5xzg5r4v83xld7np6qpj65k-python2.7-python-docx-0.8.6
/nix/store/i3nr5wlvyzzbpq7i7fz53wn24fjpxxbg-python3.6-python-docx-0.8.6

AJChapman requested a review from FRidh as a code owner April 11, 2018 05:08

GrahamcOfBorg added 6.topic: python 8.has: documentation 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Apr 11, 2018

FRidh requested changes Apr 11, 2018

View reviewed changes

dotlambda requested changes Apr 13, 2018

View reviewed changes

pythonPackages.python-docx: init at 0.8.6

cf8046e

AJChapman force-pushed the python-docx branch from ae65f42 to cf8046e Compare April 15, 2018 00:37

dotlambda merged commit 35f75cf into NixOS:master Apr 15, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

python-docx: init at 0.8.6 #38722

python-docx: init at 0.8.6 #38722

AJChapman commented Apr 11, 2018 •

edited

FRidh Apr 11, 2018

FRidh commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

FRidh commented Apr 11, 2018 •

edited

AJChapman commented Apr 11, 2018

AJChapman commented Apr 11, 2018

AJChapman commented Apr 12, 2018

dotlambda left a comment

dotlambda Apr 13, 2018

dotlambda Apr 13, 2018

dotlambda commented Apr 13, 2018

GrahamcOfBorg commented Apr 13, 2018

GrahamcOfBorg commented Apr 13, 2018

dotlambda commented Apr 13, 2018

AJChapman commented Apr 15, 2018

dotlambda commented Apr 15, 2018

GrahamcOfBorg commented Apr 15, 2018

GrahamcOfBorg commented Apr 15, 2018

python-docx: init at 0.8.6 #38722

python-docx: init at 0.8.6 #38722

Conversation

AJChapman commented Apr 11, 2018 • edited

Motivation for this change

Things done

FRidh Apr 11, 2018

Choose a reason for hiding this comment

FRidh commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

GrahamcOfBorg commented Apr 11, 2018

FRidh commented Apr 11, 2018 • edited

AJChapman commented Apr 11, 2018

AJChapman commented Apr 11, 2018

AJChapman commented Apr 12, 2018

dotlambda left a comment

Choose a reason for hiding this comment

dotlambda Apr 13, 2018

Choose a reason for hiding this comment

dotlambda Apr 13, 2018

Choose a reason for hiding this comment

dotlambda commented Apr 13, 2018

GrahamcOfBorg commented Apr 13, 2018

GrahamcOfBorg commented Apr 13, 2018

dotlambda commented Apr 13, 2018

AJChapman commented Apr 15, 2018

dotlambda commented Apr 15, 2018

GrahamcOfBorg commented Apr 15, 2018

GrahamcOfBorg commented Apr 15, 2018

AJChapman commented Apr 11, 2018 •

edited

FRidh commented Apr 11, 2018 •

edited