Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
base: c5ddf24690c2
Choose a base ref
...
head repository: jruby/jruby
compare: e3fcdb800289
Choose a head ref
  • 4 commits
  • 3 files changed
  • 1 contributor

Commits on Apr 10, 2018

  1. Use nonblocking long map and clean up imports.

    @headius
    headius committed Apr 10, 2018
    Copy the full SHA
    17cde36 View commit details
    Browse the repository at this point in the history

  2. Eliminate always-true argument.

    @headius
    headius committed Apr 10, 2018
    Copy the full SHA
    e263919 View commit details
    Browse the repository at this point in the history

  3. io1 will never be null.

    @headius
    headius committed Apr 10, 2018
    Copy the full SHA
    15898a0 View commit details
    Browse the repository at this point in the history

  4. Restructure copy_stream to avoid temporary IO around IO-like. 

    Fixes #4796.

The logic here was wrapping any non-IO, non-String, IO-like object
with a readable or writable channel wrapper, itself wrapped in a
new IO object. The outer IO object was set to not autoclose, to
avoid closing the IO-like thing it contained. However these
semantics do not fit the fully-transient nature of the pseudo-
channel, and caused the ChannelFD created to wrap it to leak in
our FilenoUtil registry.

The new logic cleans up some dead paths, renames some variables
for clarity, and avoids using an IO wrapper when we simply need
a pseduo-channel. This avoids leaking ChannelFD and fixes #4796.
    @headius
    headius committed Apr 10, 2018
    1
    Copy the full SHA
    e3fcdb8 View commit details
    Browse the repository at this point in the history