-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync built docs in master to s3 #5941
Conversation
ty, helps a lot |
.circleci/config.yml
Outdated
-e AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} \ | ||
-e AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} \ | ||
mesosphere/aws-cli \ | ||
s3 sync /docs/ s3://crystal-api/api/master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add --delete
flag to remove files that are no longer in the genetated docs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch. Adding it (and checkin the output in the next commit with a dryrun, will remove shortly)
Awesome to get this implemented! Why are there additional prepare jobs showing up in the CI results? |
@straight-shoota Branches with |
Ok, things ready here. When merged the following sync will be performedhttps://circleci.com/gh/crystal-lang/crystal/5003 The unreferenced revision.txt is will hold the exact SHA1 published for double checking. |
Otherwise maintenance fails because all test_* workspace are restored
@@ -22,7 +18,15 @@ jobs: | |||
TRAVIS_OS_NAME: linux | |||
ARCH: x86_64 | |||
ARCH_CMD: linux64 | |||
steps: *ci_steps | |||
steps: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it could be simplified to:
steps:
<<: *ci_steps
- persist_to_workspace:
root: .
paths:
- docs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wish, but yaml does not support merging arrays AFAIK.
Fix #5934 .
For every commit in master, the built docs will be published at https://crystal-lang.org/api/master