Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync built docs in master to s3 #5941

Merged
merged 2 commits into from
Apr 11, 2018
Merged

Sync built docs in master to s3 #5941

merged 2 commits into from
Apr 11, 2018

Conversation

bcardiff
Copy link
Member

Fix #5934 .

For every commit in master, the built docs will be published at https://crystal-lang.org/api/master

@bcardiff bcardiff changed the title Sync built docs in to s3 Sync built docs in master to s3 Apr 11, 2018
@ghost
Copy link

ghost commented Apr 11, 2018

ty, helps a lot

-e AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID} \
-e AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY} \
mesosphere/aws-cli \
s3 sync /docs/ s3://crystal-api/api/master
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add --delete flag to remove files that are no longer in the genetated docs.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Adding it (and checkin the output in the next commit with a dryrun, will remove shortly)

@straight-shoota
Copy link
Member

Awesome to get this implemented!

Why are there additional prepare jobs showing up in the CI results?

@bcardiff
Copy link
Member Author

@straight-shoota Branches with ci word in the branch name stress the whole release process. I should've pick other branch name instead of ci/docs. That's the reason why the extra build checks appear.

@bcardiff
Copy link
Member Author

Ok, things ready here. When merged the following sync will be performedhttps://circleci.com/gh/crystal-lang/crystal/5003

The unreferenced revision.txt is will hold the exact SHA1 published for double checking.

Otherwise maintenance fails because all test_* workspace are restored
@@ -22,7 +18,15 @@ jobs:
TRAVIS_OS_NAME: linux
ARCH: x86_64
ARCH_CMD: linux64
steps: *ci_steps
steps:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be simplified to:

steps:
  <<: *ci_steps
  - persist_to_workspace:
    root: .
    paths:
      - docs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wish, but yaml does not support merging arrays AFAIK.

@RX14 RX14 merged commit 8dd6f54 into master Apr 11, 2018
@RX14 RX14 added this to the Next milestone Apr 11, 2018
@asterite asterite deleted the ci/docs branch April 27, 2018 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants