Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump version to 2.1 #2068

Merged
merged 1 commit into from Apr 17, 2018
Merged

bump version to 2.1 #2068

merged 1 commit into from Apr 17, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Apr 10, 2018

I assume master is 2.1pre now.

@shlevy
Copy link
Member

shlevy commented Apr 10, 2018

@edolstra nix-env won't work with a 2.x daemon now that buildenv is a builtin, right? So probably we should be at 3.0?

@copumpkin
Copy link
Member

Damn, are we going to turn into Chrome and be at version 81 by next year? 😄

@edolstra
Copy link
Member

Well, this is the problem with semver I mentioned in the release RFC: every non-bug-fix release will have some minor incompatibility, so they will all cause a major version bump. At which point the minor version no longer conveys useful information (since there will never be a x.1 release).

BTW, I think we should require the daemon to be the same version as the client. That would make life a lot simpler.

@shlevy
Copy link
Member

shlevy commented Apr 11, 2018

@edolstra How would you like to proceed here then?

@Ericson2314
Copy link
Member

Ericson2314 commented Apr 12, 2018

BTW, I think we should require the daemon to be the same version as the client. That would make life a lot simpler.

Simple enough so that

every non-bug-fix release will have some minor incompatibility

is no longer true? I'd love to invalidate that fatalism somehow 😁.

@LnL7
Copy link
Member Author

LnL7 commented Apr 12, 2018

Is this important for nixUnstable? The 2.1 release could be based on master but eg. include some changes to make buildenv backwards compatible.

I would like to bump nixUnstable in nixpkgs, without having it claim to be 2.0pre. 😄

@shlevy shlevy requested review from edolstra and removed request for edolstra April 16, 2018 23:47
@shlevy shlevy added the triaged label Apr 16, 2018
@shlevy
Copy link
Member

shlevy commented Apr 16, 2018

@edolstra Thoughts?

@Ericson2314
Copy link
Member

2.1pre is strictly more accurate than 2.0pre, is it not? I say merge this now and worry about what the actual release version will be later.

@edolstra
Copy link
Member

@Ericson2314 Good point!

@edolstra edolstra merged commit 20cd1e3 into NixOS:master Apr 17, 2018
@LnL7 LnL7 deleted the version-2.1 branch April 17, 2018 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants