Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mark packages as broken for 18.03 (generic+x86_64) #38702

Merged
merged 42 commits into from Apr 17, 2018
Merged

Mark packages as broken for 18.03 (generic+x86_64) #38702

merged 42 commits into from Apr 17, 2018

Conversation

xeji
Copy link
Contributor

@xeji xeji commented Apr 10, 2018

Motivation for this change

Cleanup for 18.03, see ZHF #36453 - please backport.

Mark remaining packages that haven't built on 18.03 for a while as broken.
This PR only includes packages that don't build on master either, hence it targets master.
Any packages that build on master but not on 18.03 will be dealt with separately.

Packages will be incrementally added here.

/cc @vcunat @fpletz

@xeji xeji mentioned this pull request Apr 10, 2018
Closed
@xeji xeji requested a review from FRidh as a code owner April 11, 2018 11:50
@xeji xeji changed the title [WIP] Mark packages as broken for 18.03 (generic+x86_64) Mark packages as broken for 18.03 (generic+x86_64) Apr 11, 2018
@xeji
Copy link
Contributor Author

xeji commented Apr 11, 2018

@vcunat I'm done with this for now - please review.

xeji added 21 commits April 12, 2018 23:03
@xeji
altcoins.dcrd: mark broken on linux
54dc22f 
builds on darwin
@xeji
altcoins.dcrwallet: mark broken on linux
d0d3208 
builds on darwin
@xeji
altcoins.hevm: mark as broken
4af8328
@xeji
antimicro: mark as broken
dc3aeab
@xeji
ao: mark as broken
535f2ee
@xeji
avarice: mark as broken
1fc55ad
@xeji
avxsynth: mark as broken
d862700
@xeji
client-ip-echo: mark as broken
51cc22c
@xeji
cpp_ethereum: mark as broken
ccbefc6
@xeji
dvb_apps: mark as broken
b82170a
@xeji
gencfsm: mark as broken
0defae4
@xeji
gnokii: mark as broken
96cf58a
@xeji
ignition.transport: mark as broken
11a7c29
@xeji
imatix_gsl: mark broken on linux
5ee52f9
@xeji
jamomacore: mark as broken
68c15ce
@xeji
julia_04: mark as broken
1f8712c
@xeji
qtstyleplugin-kvantum: mark as broken
2456b4e
@xeji
lispPackages.postmodern: mark as broken
a13945e
@xeji
meshlab: mark as broken
db409ad
@xeji
mht2htm: mark as broken
9768b04
@xeji
mi2ly: mark as broken
386772b
xeji added 16 commits April 12, 2018 23:04
@Mic92 Mic92 requested review from peti and zimbatm as code owners April 12, 2018 21:04
@xeji
Copy link
Contributor Author

xeji commented Apr 12, 2018

rebased because of merge conflict

peti
peti approved these changes Apr 13, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Haskell-related part looks good to me.

@xeji
Revert "qtstyleplugin-kvantum: mark as broken"
d20c6ff 
No longer broken on master, fixed by
version bump in 35049f9.

This reverts commit 2456b4e.
zimbatm
zimbatm approved these changes Apr 15, 2018
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

vcunat added a commit that referenced this pull request Apr 17, 2018
@vcunat
Merge #38702: Mark packages as broken (ZHF)
55d7df2 
(cherry picked from commit db071c4)
@vcunat
Copy link
Member

vcunat commented Apr 17, 2018

Pushed to both branches. Thanks!

@vcunat vcunat merged commit d20c6ff into NixOS:master Apr 17, 2018
vcunat added a commit that referenced this pull request Apr 17, 2018
@vcunat
Merge #38702: Mark packages as broken (ZHF)
db071c4
@xeji xeji deleted the mark-as-broken branch April 17, 2018 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

@peti peti peti approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@xeji @vcunat @zimbatm @peti @GrahamcOfBorg