Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Add examples for parse(IO) to JSON, YAML #5936

Merged
merged 1 commit into from Apr 12, 2018
Merged

Docs: Add examples for parse(IO) to JSON, YAML #5936

merged 1 commit into from Apr 12, 2018

Conversation

straight-shoota
Copy link
Member

also fixes syntax for class methods in these docs

sdogruyol
sdogruyol reviewed Apr 11, 2018
View reviewed changes
src/json.cr Outdated
@@ -26,7 +26,18 @@
# value[0].as_i + 10 # => 11
# ```
#
# The above is useful for dealing with a dynamic JSON structure but is slower than using `JSON#mapping`.
# `JSON.parse` can read from an `IO` directly (such as a file) wich saves
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo wich -> which

@straight-shoota
Add examples for parse(IO) to JSON, YAML
89cb674 
also fixes syntax for class methods in docs
@sdogruyol
Copy link
Member

The CI failure is unrelated to this PR, LGTM 👍

@sdogruyol sdogruyol merged commit 4400657 into crystal-lang:master Apr 12, 2018
@sdogruyol sdogruyol added this to the Next milestone Apr 12, 2018
@straight-shoota straight-shoota deleted the jm/docs/json-yaml-read-file branch April 12, 2018 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdogruyol sdogruyol sdogruyol approved these changes

@RX14 RX14 RX14 approved these changes

Assignees
No one assigned
Labels
kind:docs
Projects
None yet
Milestone
0.25.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@straight-shoota @sdogruyol @RX14