New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
i3pystatus: 3.35 -> unstable #38738
i3pystatus: 3.35 -> unstable #38738
Conversation
Maybe package that as additional version so the latest stable is still available. |
Build fails on NixOS (with sandboxing):
|
// cc @dotlambda @FRidh It seems that there is no version on pypi that wants prawcore == 0.15, this is praw 5.4.0:
|
1edf2db
to
8e109bd
Compare
Tracking: tholo/pytest-flake8/issues/45 |
8e109bd leads to a rebuild of backintime-qt4 (really feels like travelling back in time...), this package has a broken install script, disabled for now in #38899 |
They seem to have switched to a rolling-release model: enkore/i3pystatus#584 (comment) |
8e109bd
to
d8f6674
Compare
rebased again with #38899 being merged nox:
|
Seems like the version requirement is unnecessarily strict: praw-dev/praw@5a8a4af |
Build works now on NixOS 18.03. I get this error when executing:
|
Regarding keyring, maybe you can convince upstream to drop the |
@@ -1,14 +1,17 @@ | |||
{ stdenv, fetchurl, libpulseaudio, python3Packages, extraLibs ? [] }: | |||
{ stdenv, fetchFromGitHub, libpulseaudio, python3Packages, extraLibs ? [] }: | |||
|
|||
python3Packages.buildPythonApplication rec { | |||
name = "${pname}-${version}"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drop this line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please elaborate, not sure what you mean.
fetchurl was for pypi, fetchFromGitHub for the rolling release version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
name
is computed from pname
and version
for buildPythonApplication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Understood, was fixed on the diff instead of the actual line :)
|
||
python3Packages.buildPythonApplication rec { | ||
name = "${pname}-${version}"; | ||
version = "3.35"; | ||
version = "2018-04-11-unstable"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please switch order of "unstable" and the date.
Also add a comment that they're using a rolling release model and link to enkore/i3pystatus#584.
@davidak confirmed :/ It only affects the clock, this did not occur when the base was different. |
0f427f9
to
b224934
Compare
@GrahamcOfBorg build i3pystatus |
Success on x86_64-linux (full log) Attempted: i3pystatus Partial log (click to expand)
|
So then we just need to figure out why suddenly the clock stopped working. |
Success on aarch64-linux (full log) Attempted: i3pystatus Partial log (click to expand)
|
This works:
|
It must doing something weird because the following works: python3 -c 'import locale; locale.setlocale(locale.LC_TIME, "en_DK.UTF-8")' |
@Mic92 thanks for investigating. Again, it worked fine with an older base. Something other than that must have changed. I am not investigating further as putting LC_TIME=C in my i3 config is close enough for me. But I feel like this should be fixed :) |
Did you try bisecting which commit in their/our history broke this? |
@mguentner What's your opinion on #38738 (comment)? |
@@ -20,7 +20,8 @@ python3Packages.buildPythonApplication rec { | |||
|
|||
libpulseaudioPath = stdenv.lib.makeLibraryPath [ libpulseaudio ]; | |||
ldWrapperSuffix = "--suffix LD_LIBRARY_PATH : \"${libpulseaudioPath}\""; | |||
makeWrapperArgs = [ ldWrapperSuffix ]; # libpulseaudio.so is loaded manually | |||
# LC_TIME != C results in locale.Error: unsupported locale setting | |||
makeWrapperArgs = [ "--set LC_TIME C" ldWrapperSuffix ]; # libpulseaudio.so is loaded manually |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
at least now it should work for everyone.
I have no opinion on that.
It's our / nixpkgs history, currently doing (since yesterday evening) a bisect. |
In that case, please drop the upper bound and get rid of the downgrade. |
Feel free to push the |
3435be1
to
493ef30
Compare
I think the "unstable" in the version should be left out because it's not unstable, there are just no versioned releases. |
Motivation for this change
no official release since 2016/08
current rev has a few new plugins available
Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)