trezord: 1.2.1 -> 2.0.12 #38704
Merged
trezord: 1.2.1 -> 2.0.12 #38704
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adisbladis
requested changes
Apr 11, 2018
pkgs/servers/trezord/default.nix
Outdated
|
|
||
| stdenv.mkDerivation rec { | ||
| name = "trezord-${version}"; | ||
| buildInputs = [clang]; |
There was a problem hiding this comment.
Rather than using clang to work around the issue you can use hardeningDisable = [ "fortify" ];.
See https://github.com/NixOS/nixpkgs/blob/b81ca435e6367ddbca29846bfb6ae3b538e67a6c/pkgs/applications/altcoins/go-ethereum.nix for an example
roconnor-blockstream
force-pushed
the
trezor
branch
from
f8b600a
to
4d2bfa3
Compare
The old trezord is obsolete and no longer functions with Trezor's password manager app.
roconnor-blockstream
force-pushed
the
trezor
branch
from
4d2bfa3
to
a60e174
Compare
|
@roconnor-blockstream Thanks for the change. Everythink looks fine now :) I want to test this with some actual Trezor hardware before merging so it's gonna have to wait until tomorrow (~12h). I'll also backport this change to |
|
Awesome! Testing now. |
|
works great! |
jb55
approved these changes
Apr 11, 2018
|
@GrahamcOfBorg eval |
|
A bit slow to backport, but here it is: 24eb7a9 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The old trezord is obsolete and no longer functions with Trezor's password manager app.
Motivation for this change
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)