Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

krakenx: init at 0.0.1 #38021

Merged
merged 1 commit into from Apr 9, 2018
Merged

krakenx: init at 0.0.1 #38021

merged 1 commit into from Apr 9, 2018

Conversation

WilliButz
Copy link
Member

@WilliButz WilliButz commented Mar 28, 2018 •
edited

This adds the python script colctl to control the colors as well as fan- and pump-speed of the NZXT Kraken X62/X52 cpu coolers.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.
  • Tested color, fan- and pump-speed control functionality

nlewo
nlewo requested changes Mar 29, 2018
View reviewed changes
pkgs/tools/system/krakenx/default.nix Outdated
@@ -0,0 +1,23 @@
{ lib, python3, python3Packages }:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove python3 since it is not used

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I was using python3.pkgs at first and forgot to remove it there %)

@WilliButz
Copy link
Member Author

@nlewo ping :)

@nlewo
Copy link
Member

nlewo commented Apr 9, 2018

@WilliButz arf, sorry I missed the notification :/
@GrahamcOfBorg build krakenx

@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: krakenx

Partial log (click to expand)

Successfully installed krakenx-0.0.1
/tmp/nix-build-krakenx-0.0.1.drv-0/krakenx-0.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/qvwpkqa6g8hjcixc4qhfy6ybljv8h7z0-krakenx-0.0.1
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/qvwpkqa6g8hjcixc4qhfy6ybljv8h7z0-krakenx-0.0.1/lib  /nix/store/qvwpkqa6g8hjcixc4qhfy6ybljv8h7z0-krakenx-0.0.1/bin
patching script interpreter paths in /nix/store/qvwpkqa6g8hjcixc4qhfy6ybljv8h7z0-krakenx-0.0.1
checking for references to /tmp/nix-build-krakenx-0.0.1.drv-0 in /nix/store/qvwpkqa6g8hjcixc4qhfy6ybljv8h7z0-krakenx-0.0.1...
wrapping `/nix/store/qvwpkqa6g8hjcixc4qhfy6ybljv8h7z0-krakenx-0.0.1/bin/colctl'...
/nix/store/qvwpkqa6g8hjcixc4qhfy6ybljv8h7z0-krakenx-0.0.1

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: krakenx

Partial log (click to expand)

Successfully installed krakenx-0.0.1
/build/krakenx-0.0.1
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/jr56i7bhnxgjnfq6b89kz721hd6m6g6r-krakenx-0.0.1
strip is /nix/store/3zq400fri5dv7d30lpxlqm2v9y1iis6j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/jr56i7bhnxgjnfq6b89kz721hd6m6g6r-krakenx-0.0.1/lib  /nix/store/jr56i7bhnxgjnfq6b89kz721hd6m6g6r-krakenx-0.0.1/bin
patching script interpreter paths in /nix/store/jr56i7bhnxgjnfq6b89kz721hd6m6g6r-krakenx-0.0.1
checking for references to /build in /nix/store/jr56i7bhnxgjnfq6b89kz721hd6m6g6r-krakenx-0.0.1...
wrapping `/nix/store/jr56i7bhnxgjnfq6b89kz721hd6m6g6r-krakenx-0.0.1/bin/colctl'...
/nix/store/jr56i7bhnxgjnfq6b89kz721hd6m6g6r-krakenx-0.0.1

@WilliButz
Copy link
Member Author

@nlewo No problem :)

@nlewo
Copy link
Member

nlewo commented Apr 9, 2018

Thanks!

@nlewo nlewo merged commit a15c578 into NixOS:master Apr 9, 2018
@WilliButz WilliButz deleted the add-krakenx branch April 9, 2018 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo requested changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@WilliButz @nlewo @GrahamcOfBorg