Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep LC_ALL #2023

Closed
wants to merge 1 commit into from
Closed

Keep LC_ALL #2023

wants to merge 1 commit into from

Conversation

matthewbauer
Copy link
Member

LC_ALL is often needed by programs to detect what locale to output in. This can be safely passed to pure nix-build.

LC_ALL is often needed by programs to detect what locale to output in. This can be safely passed to pure nix-build.
@edolstra
Copy link
Member

I don't think that this is a good idea in pure mode. The whole point of pure mode is not to be infected by those kinds of environment variables. A quick grep of Nixpkgs shows dozens of packages that set LC_ALL, so there is plenty of evidence of LC_ALL having a material effect on build results.

@7c6f434c
Copy link
Member

From that point of view, HOME, USER and DISPLAY also sound like something that will affect the build.

@shlevy
Copy link
Member

shlevy commented Mar 29, 2018

In my experience the only effect LC_ALL seems to have is whether it's set or not (or sometimes whether it's set to a utf-8 locale or not)... Are there counterexamples?

@globin
Copy link
Member

globin commented Mar 29, 2018

There are quite a few python packages that depend on a UTF-8 locale for running tests, most of those are set because of that.

@shlevy
Copy link
Member

shlevy commented Mar 29, 2018

Is there a strong reason not to just set a UTF-8 locale in stdenv? Then it seems like respecting the user's LC_ALL would be much less of a divergence.

@matthewbauer
Copy link
Member Author

I wonder if it really is a python issue then... It should be able to default to the "C" locale - but for whatever reason that never happens. Anyway, I'm convinced this probably isn't the place to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants