Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/monit: restart if config changes #38020

Merged
merged 1 commit into from Mar 29, 2018
Merged

nixos/monit: restart if config changes #38020

merged 1 commit into from Mar 29, 2018

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Mar 28, 2018

Motivation for this change

Monit did not restart if the config changed before.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@wmertens
Copy link
Contributor

LGTM 👍

@wmertens wmertens merged commit 97f9378 into NixOS:master Mar 29, 2018
@ryantm ryantm deleted the monit-reload branch March 29, 2018 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ryantm @wmertens @GrahamcOfBorg