emscripten: use matching binaryen version #37427
Merged
+23
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build emscriptenPackages.binaryen |
|
No attempt on x86_64-linux (full log) The following builds were skipped because they don't evaluate on x86_64-linux: emscriptenPackages.binaryen Partial log (click to expand)
|
|
No attempt on aarch64-linux The following builds were skipped because they don't evaluate on aarch64-linux: emscriptenPackages.binaryen No partial log is available. |
|
No attempt on x86_64-darwin The following builds were skipped because they don't evaluate on x86_64-darwin: emscriptenPackages.binaryen No partial log is available. |
This changes the emscripten package so that it specifies the rev from the binaryen repo to use, and sets it to always use the version that has been tagged for use with that version of emscripten. This should force future updates of emscripten to also update binaryen. Binaryen can also be installed as a stand-alone package, so there's some logic added to the binaryen package to allow building in both ways, and distinguishing between them.
asppsa
force-pushed
the
binaryen-emscripten-version2
branch
from
eeb5fb2 to
adb8020
Compare
asppsa
changed the title
|
Sorry @GrahamcOfBorg, I formatted the commit incorrectly :( |
|
@GrahamcOfBorg build emscripten binaryen |
|
cc @qknight |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the emscripten package so that it specifies the rev from
the binaryen repo to use, and sets it to always use the version that has
been tagged for use with that version of emscripten. This should force
future updates of emscripten to also update binaryen.
Binaryen can also be installed as a stand-alone package, so there's some
logic added to the binaryen package to allow building in both ways, and
distinguishing between them.
Motivation for this change
The reason for this change is that the emscripten-binaryen relationship seems quite brittle -- using the wrong version of binaryen seems to make emscripten unreliable.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)