[17.09] firefox: fix build #37457
Merged
[17.09] firefox: fix build #37457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 16ee6b5)
pbogdan
changed the title
|
esr looks to be fine as well. |
|
Mhm, I thought I build that successfully on one of my machines... Sorry for the trouble. Why was the additional commit (not the nss bump) required? Did that break? |
|
Without it the build failed the same way as in your comment here - #37309 (comment), it seems 17.09 backport didn't include that change? |
|
I'm running a rebuild on one of my machines right now. If anyone is faster and can confirm less breakage go ahead :-) |
|
Does build for me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Firefox fails to build on 17.09 - https://hydra.nixos.org/build/71543368/ Only tested firefox for now (which looks to build and work fine - only basic usage tested though). Currently waiting on firefox-esr to finish building.
nss update triggers a substantial rebuild, I don't have capacity to test the build of all the reverse dependencies and am unsure on how risky the update is.
/cc @vcunat @andir
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)