python*: set thread stack size on musl #37447

dtzWill · 2018-03-20T13:20:14Z

Ensure recursion limit is reached before stack overflow.

Manual testing via Alpine's test-stacksize.py crashes on these
previously, and works with these changes.

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

Ensure recursion limit is reached before stack overflow. Python does this for OSX and BSD: https://github.com/python/cpython/blob/13ff24582c99dfb439b1af7295b401415e7eb05b/Python/thread_pthread.h#L22 Size of 1MB chosen to match value in Alpine: https://git.alpinelinux.org/cgit/aports/commit/main/python2/APKBUILD?id=2f35283fec8ec451fe5fb477dd32ffdcc0776e89 Manual testing via Alpine's test-stacksize.py crashes on these previously, and works with these changes.

dtzWill requested a review from FRidh as a code owner March 20, 2018 13:20

GrahamcOfBorg added 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0 labels Mar 20, 2018

dtzWill merged commit 0682857 into NixOS:master Mar 20, 2018

dtzWill deleted the fix/python-musl-thread-stacksize branch March 20, 2018 14:17

Provide feedback