Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: de0ea1dd18e7
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 06828573e700
Choose a head ref
  • 2 commits
  • 4 files changed
  • 2 contributors

Commits on Mar 20, 2018

  1. python*: set thread stack size on musl 

    Ensure recursion limit is reached before stack overflow.

Python does this for OSX and BSD:
https://github.com/python/cpython/blob/13ff24582c99dfb439b1af7295b401415e7eb05b/Python/thread_pthread.h#L22

Size of 1MB chosen to match value in Alpine:
https://git.alpinelinux.org/cgit/aports/commit/main/python2/APKBUILD?id=2f35283fec8ec451fe5fb477dd32ffdcc0776e89

Manual testing via Alpine's test-stacksize.py crashes on these
previously, and works with these changes.
    @dtzWill
    dtzWill committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    9aa2219 View commit details
    Browse the repository at this point in the history

  2. Merge pull request #37447 from dtzWill/fix/python-musl-thread-stacksize 

    python*: set thread stack size on musl
    @dtzWill
    dtzWill committed Mar 20, 2018
    Configuration menu
    Copy the full SHA
    0682857 View commit details
    Browse the repository at this point in the history